Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore missing "Page by date" Views pager plugin #2766

Open
Al-Rozhkov opened this issue Jul 12, 2017 · 13 comments
Open

Restore missing "Page by date" Views pager plugin #2766

Al-Rozhkov opened this issue Jul 12, 2017 · 13 comments

Comments

@Al-Rozhkov
Copy link
Member

@Al-Rozhkov Al-Rozhkov commented Jul 12, 2017

Date module was merged to Backdrop core in version 1.2.0

For some reason one views pager plugin wasn't ported (date_views\includes\date_views_plugin_pager.inc). I wonder was it intentional or wasn't. @Graham-72 and me going to finish port of much needed Calendar module which is depend on that pager plugin. So we need to decide how to recover pager plugin.

If removal wasn't intentional, we can restore pager in Backdrop core 1.8.0. Until then we can include pager in Calendar module beta release. At the time of release 1.8.0 we can make stable version of Calendar which will depend on 1.8.0 core.

Respective issue in Calendar queue.


PR: backdrop/backdrop#1928

@Al-Rozhkov

This comment has been minimized.

Copy link
Member Author

@Al-Rozhkov Al-Rozhkov commented Jul 13, 2017

I have read Add date (field) module to core carefully and looks like it wasn't intentional to exclude something from date_views module. Not only pager plugin is missing. Argument handler for date fields which is responsible for views contextual filters doesn't work, although date_views_argument_handler.inc file is there.

Quote from @quicksketch comment:

Disadvantages: This is a bit rushed and we probably have some bugs that we have introduced.

The port is looks incomplete. I'm going to provide PR to fix this.

@Al-Rozhkov

This comment has been minimized.

Copy link
Member Author

@Al-Rozhkov Al-Rozhkov commented Jul 13, 2017

I have set up an example view on sandbox site with pager by date: http://1928.backdrop.backdrop.qa.backdropcms.org/page-by-date

Check out "Prev/Next" links on the top of the view.

@klonos

This comment has been minimized.

Copy link
Member

@klonos klonos commented Jul 15, 2017

Thank you for taking initiative on this @Al-Rozhkov 👍

@Al-Rozhkov

This comment has been minimized.

Copy link
Member Author

@Al-Rozhkov Al-Rozhkov commented Jul 15, 2017

Is it ok to add 1.8.0 milestone for this one?

@serundeputy serundeputy added this to the 1.8.0 milestone Jul 15, 2017
@jenlampton

This comment has been minimized.

Copy link
Member

@jenlampton jenlampton commented Aug 17, 2017

Yes, thank you @Al-Rozhkov for catching the oversight. I'd love to see this get into 1.8! I know this was "missing" from the port of Date module, but it is still adding a feature to core. Going to tag it as a feature request (as well as a bug).

@jenlampton

This comment has been minimized.

Copy link
Member

@jenlampton jenlampton commented Aug 17, 2017

I gave the PR a quick code review and left some feedback. Overall, it looks great! There are a few things in the old Drupal code that were not up to snuff with Backdrop standards, a few minor cleanups needed, and I had a few questions. Otherwise, this looks super close!

@quicksketch

This comment has been minimized.

Copy link
Member

@quicksketch quicksketch commented Aug 19, 2017

PR needs some adjustments, mostly small though. Moving this to needs work.

@Al-Rozhkov

This comment has been minimized.

Copy link
Member Author

@Al-Rozhkov Al-Rozhkov commented Aug 20, 2017

Thank you for review. I pushed changes based on your comments.
I'm not sure about deleted variables in date_views_argument_handler_simple class. Everything works without them.

@quicksketch

This comment has been minimized.

Copy link
Member

@quicksketch quicksketch commented Aug 20, 2017

I'm not sure about deleted variables in date_views_argument_handler_simple class. Everything works without them.

Yeah, PHP doesn't require you to define properties used within an object, but including them provides you a way to document what is expected within the object. IDE's like PHPStorm also will use the property documentation to provide code-hints, and will hightlight unexpected properties as a possible bug, this can help you catch typos in your property names. We should leave them in place.

I'm not quite sure how to test these changes. For new features like this that is somewhat on the fringe of functionality, we should add new test coverage.

@jenlampton

This comment has been minimized.

Copy link
Member

@jenlampton jenlampton commented Sep 5, 2017

Looks like this still needs some work, and with code-freeze in just a few hours I'm going to bump the milestone.

@jenlampton jenlampton modified the milestones: 1.9.0, 1.8.0 Sep 5, 2017
@Al-Rozhkov Al-Rozhkov removed their assignment Dec 23, 2017
@jenlampton

This comment has been minimized.

Copy link
Member

@jenlampton jenlampton commented Jan 15, 2018

Looks like this still needs some work, and with no attention since the last release, I'm going to remove the milestone. Should we get a PR ready we can always add one back.

@jenlampton jenlampton removed this from the 1.9.0 milestone Jan 15, 2018
@stpaultim

This comment has been minimized.

Copy link
Member

@stpaultim stpaultim commented Jan 29, 2020

Post in forum says that calendar modules release is blocked by this issue:
https://forum.backdropcms.org/forum/calendar-module?page=0%2C0#comment-1666

What needs to happen with this issue/PR? Is it just waiting for tests?

@olafgrabienski

This comment has been minimized.

Copy link

@olafgrabienski olafgrabienski commented Mar 24, 2020

If I understand the forum post https://forum.backdropcms.org/forum/event-list-view-list-filter-months correctly, it's not possible to filter a view by month in Backdrop. If that's the case and if this issue is the reason: Let's finish this fix. How can I help (other than by writing tests)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
8 participants
You can’t perform that action at this time.