[UX] Better module uninstallation confirm form.

[klonos]

Before:

After:

---

PR by @klonos: backdrop/backdrop#2220

[klonos]

In this PR:

• moved the "Would you like ..." text to the confirmation page title (same as done for confirming deleting content)
• Converted the "all data will be lost" text to a warning (we were previously emphasising it using <em> tags)
• removed the now redundant "Would you like to continue with uninstalling the above?" question, as it was repeating what is already being asked in the form title.
• changed "Would you like ...?" to "Are you sure ...?"

[olafgrabienski]

Are you sure you want to continue with uninstalling the modules listed bellow?

@klonos There's a small typo at the end of the sentence: "bellow" (two l)

[klonos]

Good catch @olafgrabienski 👍 ...fixed!

[opi]

In the 2nd screenshot, the lonely bullet list without heading feels a little lost

[klonos]

I hear ya @opi, but the text that was previously there has been moved to the page title and the warning. There was nothing left 😄 ...any suggestion?

[quicksketch]

I often find that putting an entire sentence in the title to be ineffective for my reading. As I skim over the entire header area to read the "content" area. What I read on this page after the changes is the status message, the bullet list, and the buttons. I miss the header title entirely.

So I think a solution that would solve the lonely bullet list and my title problem would be keeping the title "Confirm uninstall" and moving the question sentence into the body area.

[klonos]

I have updated the PR. Better now?:

[opi]

Yay! Marking as RTBC.
@quicksketch please squash the 3 commits before merge to keep a clean git history.

[klonos]

@quicksketch always squashes 😄

[quicksketch]

Thanks folks! Merged backdrop/backdrop#2220 into 1.x. Though this could be included in 1.10, as we're so close to 1.11 it's better to avoid unnecessarily changing strings used in translations.

[quicksketch]

Also, per @herbdool's PR comment, I reverted the title change. It had been changed to "Confirm uninstallation", I reverted it back to "Confirm uninstall". The body and message area is the big win here.