Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Contact form categories: recipients should be rendered as a list #3216

Closed
klonos opened this issue Jul 28, 2018 · 9 comments
Closed

[UX] Contact form categories: recipients should be rendered as a list #3216

klonos opened this issue Jul 28, 2018 · 9 comments

Comments

@klonos
Copy link
Member

klonos commented Jul 28, 2018

Part of the #3023 META...

Current situation (single line of text w/o spaces):

screen shot 2018-07-28 at 10 48 38 pm

These should be rendered as a list.


PR backdrop/backdrop#2256

@klonos klonos changed the title [UX] Contact categories: recipients should be rendered as a list [UX] Contact form categories: recipients should be rendered as a list Jul 28, 2018
@opi
Copy link

opi commented Jul 30, 2018

from #2872 (comment)

We could be sorting email addresses alphabetically for an added bonus. This would help in cases where these lists get long. I would first go by grouping by domain, then alpha sorting for each domain.

I agree with rendering recipients as list, but sorting addresses alphabetically, and/or by domain can be confusing for user : The recipients order would be different between the overview page and the category edit form. Not sure this is good UX.

@opi
Copy link

opi commented Jul 30, 2018

backdrop/backdrop#2256 simple PR with a line break added for each recipient address.

@klonos
Copy link
Member Author

klonos commented Jul 30, 2018

Agreed about the alpha order, but I still think that it'd be better to have the emails rendered as a list. That is the best option semantically (because it is a list of things), and this is the pattern being followed elsewhere in the admin UI:

screen shot 2018-07-30 at 10 17 21 pm

@opi
Copy link

opi commented Jul 30, 2018

PR updated with a proper <ul><li> structure. Note that this structure is used even with only one recipient.

@klonos
Copy link
Member Author

klonos commented Jul 31, 2018

Note that this structure is used even with only one recipient.

That's what currently happens with the list of roles in the user account page too. I personally do not find this annoying in these cases. It is just a clearer indication that this specific thing can have more than one items.

its good

@klonos
Copy link
Member Author

klonos commented Jul 31, 2018

I have left a minor comment in the PR, but in general RTBC from me 😄

@opi
Copy link

opi commented Jul 31, 2018

Using theme('item_list') now as suggested by @klonos ; I guess we're RTBC now, if you can review a last time and set the proper label, thx !

@klonos
Copy link
Member Author

klonos commented Jul 31, 2018

Poifect! RTBC from me 👍

@quicksketch
Copy link
Member

Thanks @opi and @klonos! Merged backdrop/backdrop#2256 into 1.x for 1.11.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants