Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need ability to set color of primary tab so custom themes are not ugly #3286

Closed
herbdool opened this issue Sep 12, 2018 · 2 comments
Closed

Comments

@herbdool
Copy link

Describe your issue or idea

Because the primary tabs aren't a color option in Basis, it means that it's easy to make ugly looking color schemes. I'm going to be controversial and mark this as a bug (though even as a UI tweak might make it into 1.11.x?).

Steps to reproduce (if reporting a bug)

Create some color schemes like "Tropical" in this PR backdrop/backdrop#2299.

Actual behavior (if reporting a bug)

45274677-7a94f580-b486-11e8-9981-7e35f0dc2b67

Expected behavior (if reporting a bug)

Primary tabs should be a color option so that it can be controlled better.

Tested with 1.11.x-dev

@herbdool herbdool added this to the 1.11.0 milestone Sep 12, 2018
@herbdool herbdool changed the title Need ability to set color of primary tab Need ability to set color of primary tab so custom themes are not ugly Sep 12, 2018
@quicksketch
Copy link
Member

This looks good to me. With the problems noted in backdrop/backdrop#2299, this seems like the magic blending approach isn't going to cut it for Basis.

@quicksketch
Copy link
Member

PR was minimal and reviewed by @oadaeh. Merged backdrop/backdrop#2303 into 1.x for 1.11.0. Thanks @herbdool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants