New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX] Change "Theming" to "Theme" or "Theme developer" throughout core #3658
Comments
@jenlampton this is set to NT/NR, but no PR 😅 |
doh, sorry: backdrop/backdrop#2570 |
I have removed the NT tag, since all changes are in docblocks, and some labels or help text. I left a couple of comments and a question in the PR, but overall this looks great 👍. Thanks. |
Don't we need to test these? Confirm I didn't delete a |
All such changes are limited in |
The changes made didn't break anything for me. However, there were two typos I pointed out |
@nicolascrossi if you see something in the PR that needs work, you are welcome to add the tag |
Pushed an updated PR with the fixed addressed. @nicolascrossi I didn't see any comments on the PR from you about typos. If you started a multi-comment review, can you make sure that it was actually submitted? Sometimes that trips me up and I never actually add my comments :( |
…and accurate word. By @jenlampton, @nicolascrossi, and @klonos.
…and accurate word. By @jenlampton, @nicolascrossi, and @klonos.
Merged backdrop/backdrop#2570 into 1.x and 1.13.x. Thanks @jenlampton, @nicolascrossi, and @klonos! |
I've noticed that throughout core we use the word "theming" all over the place, for all different kinds of meanings. Sometimes we do mean
the act of creating a theme
but more often than not we simply meanrendering
or evenmarkup
.I'm going to take a pass through core and see if I can replace this word (mostly in documentation) with a more specific alternative, better suited to the intended meaning.
PR: backdrop/backdrop#2570
The text was updated successfully, but these errors were encountered: