Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Change "Theming" to "Theme" or "Theme developer" throughout core #3658

Closed
jenlampton opened this issue Apr 7, 2019 · 9 comments · Fixed by backdrop/backdrop#2570
Closed

Comments

@jenlampton
Copy link
Member

jenlampton commented Apr 7, 2019

I've noticed that throughout core we use the word "theming" all over the place, for all different kinds of meanings. Sometimes we do mean the act of creating a theme but more often than not we simply mean rendering or even markup.

I'm going to take a pass through core and see if I can replace this word (mostly in documentation) with a more specific alternative, better suited to the intended meaning.


PR: backdrop/backdrop#2570

@jenlampton jenlampton changed the title [UX] Change "Theming" to "Theme development" throughout core [UX] Change "Theming" to "Theme" or "Theme developer" throughout core Apr 7, 2019
@klonos
Copy link
Member

klonos commented Apr 7, 2019

@jenlampton this is set to NT/NR, but no PR 😅

@jenlampton
Copy link
Member Author

doh, sorry: backdrop/backdrop#2570

@klonos
Copy link
Member

klonos commented Apr 7, 2019

I have removed the NT tag, since all changes are in docblocks, and some labels or help text.

I left a couple of comments and a question in the PR, but overall this looks great 👍. Thanks.

@jenlampton
Copy link
Member Author

and some labels or help text.

Don't we need to test these? Confirm I didn't delete a ; and break everything?

@klonos
Copy link
Member

klonos commented Apr 10, 2019

All such changes are limited in core/modules/views/plugins/views_plugin_display.inc . I will test them when I get a chance ...unless anyone beats me to it 😄

@nicolascrossi
Copy link

The changes made didn't break anything for me. However, there were two typos I pointed out

@nicolascrossi nicolascrossi removed their assignment Apr 20, 2019
@matthui matthui self-assigned this Apr 30, 2019
@jenlampton
Copy link
Member Author

jenlampton commented May 16, 2019

@nicolascrossi if you see something in the PR that needs work, you are welcome to add the tag pr - needs work. If everything works for you, you can also add the tag pr - works for me

@jenlampton
Copy link
Member Author

Pushed an updated PR with the fixed addressed. @nicolascrossi I didn't see any comments on the PR from you about typos. If you started a multi-comment review, can you make sure that it was actually submitted? Sometimes that trips me up and I never actually add my comments :(

@quicksketch
Copy link
Member

Merged backdrop/backdrop#2570 into 1.x and 1.13.x. Thanks @jenlampton, @nicolascrossi, and @klonos!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment