Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misleading description for 'Trimmed limit' setting on long text fields #3828

Closed
ghost opened this issue May 30, 2019 · 5 comments · Fixed by backdrop/backdrop#2712
Closed

Misleading description for 'Trimmed limit' setting on long text fields #3828

ghost opened this issue May 30, 2019 · 5 comments · Fixed by backdrop/backdrop#2712
Labels
status - fixed status - has pull request type - bug report
Milestone
1.25.2

Comments

@ghost
Copy link

ghost commented May 30, 2019

When configuring the 'Trimmed' field format, the 'Trimmed limit' setting has the following description:

If the summary is not set, the trimmed [FIELD] field will be shorter than this character limit.

This description is the same for both the 'Summary or trimmed' and 'Trimmed' formats. It makes sense for the 'Summary or trimmed' format, but the 'Trimmed' format doesn't take the text's summary into consideration when trimming, so this is misleading. THe description should be changed for the 'Trimmed' format.

image
@ghost ghost mentioned this issue May 31, 2019
Merged
@ghost
Copy link
Author

ghost commented May 31, 2019

Made a PR that fixes this by changing the description text for the 'Trimmed' format: backdrop/backdrop#2712

@ghost
Copy link
Author

ghost commented Jan 28, 2022

The description is now just:

The trimmed %label field will be shorter than this character limit.

PR updated for Tugboat and test suite.

@laryn
Copy link
Contributor

laryn commented Feb 20, 2023

WFM and code looks good. 👍

@laryn laryn added this to the 1.24.1 milestone Feb 20, 2023
@jenlampton jenlampton modified the milestones: 1.24.1, 1.24.2 Mar 15, 2023
@jenlampton jenlampton modified the milestones: 1.24.2, 1.24.3 Apr 19, 2023
@klonos klonos modified the milestones: 1.24.3, 1.25.1 Jun 6, 2023
@quicksketch quicksketch modified the milestones: 1.25.1, 1.25.2 Jun 7, 2023
@argiepiano
Copy link

RTBC!

backdrop-ci referenced this issue in backdrop/backdrop Sep 13, 2023
Issue #3828: Fix misleading description for 'Trimmed limit' setting o…
c18768d 
…n long text fields.

By @BWPanda, @argiepiano, and @laryn.
@quicksketch quicksketch changed the title Misleading description text for 'Trimmed limit' setting Misleading description for 'Trimmed limit' setting on long text fields Sep 13, 2023
@quicksketch
Copy link
Member

Thanks folks! I merged backdrop/backdrop#2712 into 1.x and 1.25.x.

backdrop-ci referenced this issue in backdrop/backdrop Sep 13, 2023
@quicksketch
Issue #3828: Fix misleading description for 'Trimmed limit' setting o…
9959faa 
…n long text fields.

By @BWPanda, @argiepiano, and @laryn.
@quicksketch quicksketch mentioned this issue Sep 15, 2023
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status - fixed status - has pull request type - bug report
Projects
None yet
Milestone
1.25.2
Development

Successfully merging a pull request may close this issue.

Changed misleading description for 'Trimmed limit' setting. BWPanda/backdrop
5 participants
@quicksketch @jenlampton @laryn @klonos @argiepiano