Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Views Pager - More Link not working #3910

Open
stpaultim opened this issue Jul 1, 2019 · 4 comments
Open

Views Pager - More Link not working #3910

stpaultim opened this issue Jul 1, 2019 · 4 comments

Comments

@stpaultim
Copy link
Member

Description of the bug
The "More Link" on the page for views is not working.

Steps To Reproduce
I will come back later and try to create better steps, but for now I've created a view with test content. I checked the "more link" on the pager, but when I display the view and click on the "more" link, nothing happens.

I tested this with two different sites and different types of data. I don't know if this was working before.

Page_View__Content____Backdrop

Actual behavior

Expected behavior

Additional information
Add any other information that could help, such as:

  • Backdrop CMS version: 1.13.2
  • Web server and its version: Running site locally with lando on Mac OS
  • Browser(s) and their versions: Chrome
@olafgrabienski
Copy link

Confirmed! Tested in 1.13.x with a page display. The "more" link just points to the path of the views page.

@indigoxela
Copy link
Member

indigoxela commented Jul 1, 2019

The problem is, that the option for the view link url seems to be missing.

In Drupal 7 it's below "Advanced | Other | Link display"
Setting the "more" link has never been very user friendly in Drupal 7, but in Backdrop I don't find that setting anywhere.

Drupal 8 puts the setting directly to the link text setting below "Pager".

@stpaultim
Copy link
Member Author

I don't know if this was necessary, but I tested an older version of Backdrop, version 1.9.x-dev to see if the problem has been around a while or recently introduced. I'm seeing the same problem in 1.9.x-dev.

@indigoxela
Copy link
Member

indigoxela commented Jul 2, 2019

Ah, got it... the setting is there, but only under certain conditions.

It happens in core/modules/views/plugins/views_plugin_display.inc

'#description' => t("This will add a more link to the bottom of this view, which will link to the page view. If you have more than one page view, the link will point to the display specified in 'Link display' section under advanced. You can override the url at the link display setting.")

So the thing is, that the "More link:" setting (to use one) is always there, but the "Link display:" setting beneath "Other | Link display" (override the default url) only appears for displays not using a path, hence not for pages.

More precise: in class views_plugin_display, function uses_link_display() { return !$this->has_path(); } checks whether or not to show the setting to override the url.

By default the url is the one of the first page display. This works correctly for blocks. It is also possible to set the "more link" for pages, but it's impossible to override the url there.

It's not actually a bug, but it's a horrible, horrible user interface and it's the same as in D7.

This is a screenshot of the setting, I'm talking about (block display):

screenshot-views-link-options-block

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants