Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CKEditor button images #4026

Open
herbdool opened this issue Sep 11, 2019 · 6 comments
Open

Update CKEditor button images #4026

herbdool opened this issue Sep 11, 2019 · 6 comments

Comments

@herbdool
Copy link

herbdool commented Sep 11, 2019

Description of the bug
The CKeditor buttons in the admin settings look different from the front end. I first noticed it with the Table button and the Source button.

The admin page:
Screenshot from 2019-09-10 22-35-04

Add a node form:
Screenshot from 2019-09-10 22-34-51

I viewed this in 1.14.x and 1.13.x.

@ghost
Copy link

ghost commented Oct 16, 2020

Hmm, interesting! Confirmed in latest 1.18.x...

@indigoxela
Copy link
Member

It seems like the "admin buttons" in core/modules/ckeditor/images/buttons/ should be updated to the recent versions from core/misc/ckeditor/plugins. 😉

@ghost
Copy link

ghost commented Oct 16, 2020

I started doing this PR, only to get to the end of the images and realise that the source I was using didn't have all the ones I needed... So adding my PR here so as not to lose all my work, but this still needs work.

Going to change this from a bug to a task, since it's just a visual difference.

@ghost ghost changed the title Front and backend of CKeditor show different icons Update CKEditor button images Oct 16, 2020
@indigoxela
Copy link
Member

only to get to the end of the images and realise that the source I was using didn't have all the ones I needed

I'm not sure, but it might be that CKEditor is using sprite images.

@ghost
Copy link

ghost commented Oct 16, 2020

Yes, that's what I used for the PR changes, but there aren't as many images there as are in https://github.com/backdrop/backdrop/tree/1.x/core/modules/ckeditor/images/buttons...

@indigoxela
Copy link
Member

but there aren't as many images there as are in core/modules/ckeditor/images/buttons...

I see. Maybe they're not in use anymore? But it's probably easiest if you replace the ones you have available in the sprite and keep the other (older) ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants