Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Replace double dashes with middot in menu parent select list #4218

Closed
quicksketch opened this issue Nov 20, 2019 · 11 comments
Closed

[UX] Replace double dashes with middot in menu parent select list #4218

quicksketch opened this issue Nov 20, 2019 · 11 comments

Comments

@quicksketch
Copy link
Member

quicksketch commented Nov 20, 2019

Description of the need
Currently when selecting a menu item, we use two dashes to indicate a level in the hierarchy:

image

The double-dashes can be difficult to determine exactly how many levels something is in the hierarchy (number of dashes divided by two).

Proposed solution

It might make things easier to read if we used a single character per hierarchical level, such as a square bullet.


PR by @verygladden: backdrop/backdrop#3078

@olafgrabienski
Copy link

Interesting! As an experiment, I've replaced the double dashes using my browser's dev tools with different signs, e.g.

  • (n dash)
  • >
  • · (middot)

The middots, separated by a space, gave the best result so far. Here's a screenshot:

backdrop-menu-dropdown-middots

@klonos
Copy link
Member

klonos commented Nov 21, 2019

I like the middots better @olafgrabienski 👍 ...will you be able to file a PR for it?

PS: I would like us to eventually implement a more user-friendly and familiar way (reuse UI patterns) for selecting menus. What is proposed in #3029 basically. That would provide the best UX; but this is a nice improvement in the interim.

@olafgrabienski
Copy link

Thanks for your feedback @klonos ! I'm still short of time and the issue doesn't seem to be urgent, so unfortunately no PR from me.

Apart of that, I'm indecisive about the middots: They look good but at the same time uncommon. Are (single) dashes maybe better because more common? Here's a comparison:

Single dashes:

screen-backdrop-menu-dropdown-dashes

Middots:

backdrop-menu-dropdown-middots

@olafgrabienski
Copy link

olafgrabienski commented Nov 25, 2019

As a side note, looking at the select list, I noticed the angle brackets around top level items, e.g. <Primary navigation>. Do we need those brackets? In my opinion, the list is better readable without. Have a look at the following comparison:

<Primary navigation>
- Home
- About
-- History
- Portfolio
- Contact
Primary navigation
- Home
- About
-- History
- Portfolio
- Contact

@quicksketch
Copy link
Member Author

I'm in favor of removing the angle brackets. A lot of sites only have a single menu available (like the out-of-box functionality).

As for middot vs. dashes, I think the middot is a lot more readable than the dash. It's easy to count the level of indentation, as opposed to dashes where they all run together.

@olafgrabienski
Copy link

Thanks for your feedback, @quicksketch! I'd like to make a last comparison between middots, separated by a space (as above) vs. middots without separation:

(1) Middot + space:

Primary navigation
· Home
· About
· · History
· · · 2019
· · · 2018
· · · 2017
· Portfolio
· Contact

(2) Just middot:

Primary navigation
· Home
· About
·· History
··· 2019
··· 2018
··· 2017
· Portfolio
· Contact

Okay, in my opinion it looks better with space.

@olafgrabienski
Copy link

will you be able to file a PR for it?

@klonos I might find some time soon but have not the minimal idea where the characters for the menu item select list are defined. Do you have an idea or can you give me a hint where to look?

@indigoxela
Copy link
Member

@olafgrabienski this hides in function _menu_get_options

@verygladden
Copy link

verygladden commented Feb 18, 2020

I made a PR that should fix this issue. backdrop/backdrop#3078

@olafgrabienski
Copy link

@verygladden Thanks for the PR, and welcome to Backdrop!

I've tested the PR in the sandbox website (http://3078.backdrop.backdrop.qa.backdropcms.org), looks good to me! Here's a screenshot from the sandbox site:

screen-backdrop-pr-3078-menu-select

I'd be happy if someone else could make the code review.

@ghost
Copy link

ghost commented Mar 11, 2020

Merged backdrop/backdrop#3078 into 1.x. Thanks @quicksketch for the suggestion, and to @olafgrabienski & @herbdool for the reviews and feedback! And a very big thank you to @verygladden for the PR! Congrats on your first official contribution to Backdrop core 😃

@ghost ghost added this to the 1.16.0 milestone Mar 12, 2020
@jenlampton jenlampton changed the title [UX] Replace double dashes (hyphens) with single character in menu parent select list [UX] Replace double dashes with middot in menu parent select list May 15, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants