New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX] Replace double dashes with middot in menu parent select list #4218
Comments
I like the middots better @olafgrabienski 👍 ...will you be able to file a PR for it? PS: I would like us to eventually implement a more user-friendly and familiar way (reuse UI patterns) for selecting menus. What is proposed in #3029 basically. That would provide the best UX; but this is a nice improvement in the interim. |
Thanks for your feedback @klonos ! I'm still short of time and the issue doesn't seem to be urgent, so unfortunately no PR from me. Apart of that, I'm indecisive about the middots: They look good but at the same time uncommon. Are (single) dashes maybe better because more common? Here's a comparison: Single dashes: Middots: |
As a side note, looking at the select list, I noticed the angle brackets around top level items, e.g.
|
I'm in favor of removing the angle brackets. A lot of sites only have a single menu available (like the out-of-box functionality). As for middot vs. dashes, I think the middot is a lot more readable than the dash. It's easy to count the level of indentation, as opposed to dashes where they all run together. |
Thanks for your feedback, @quicksketch! I'd like to make a last comparison between middots, separated by a space (as above) vs. middots without separation: (1) Middot + space: Primary navigation (2) Just middot: Primary navigation Okay, in my opinion it looks better with space. |
@klonos I might find some time soon but have not the minimal idea where the characters for the menu item select list are defined. Do you have an idea or can you give me a hint where to look? |
@olafgrabienski this hides in function _menu_get_options |
I made a PR that should fix this issue. backdrop/backdrop#3078 |
@verygladden Thanks for the PR, and welcome to Backdrop! I've tested the PR in the sandbox website (http://3078.backdrop.backdrop.qa.backdropcms.org), looks good to me! Here's a screenshot from the sandbox site: I'd be happy if someone else could make the code review. |
Merged backdrop/backdrop#3078 into 1.x. Thanks @quicksketch for the suggestion, and to @olafgrabienski & @herbdool for the reviews and feedback! And a very big thank you to @verygladden for the PR! Congrats on your first official contribution to Backdrop core 😃 |
Description of the need
Currently when selecting a menu item, we use two dashes to indicate a level in the hierarchy:
The double-dashes can be difficult to determine exactly how many levels something is in the hierarchy (number of dashes divided by two).
Proposed solution
It might make things easier to read if we used a single character per hierarchical level, such as a square bullet.
PR by @verygladden: backdrop/backdrop#3078
The text was updated successfully, but these errors were encountered: