Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Updater: Misleading text/steps in authorize.php #4304

Open
klonos opened this issue Feb 9, 2020 · 1 comment
Open

[UX] Updater: Misleading text/steps in authorize.php #4304

klonos opened this issue Feb 9, 2020 · 1 comment

Comments

@klonos
Copy link
Member

klonos commented Feb 9, 2020

Description of the bug
A short description of what the problem is.

Steps To Reproduce
To reproduce the behavior:

  1. Install an older version of a module, either manually, or via the Project Browser (in this case, I have installed Honeypot 1.0.2, with the latest being 1.26.0)
  2. Start the process of updating the module via the admin UI, follow the steps as usual, accepting the defaults as you go (put the site into maintenance mode etc.)

Actual behavior
When the update is finished, you see the following screen:

Screen Shot 2020-02-09 at 3 48 13 pm

...since the only next step is to run the db updates, do that ...only to find out that there no db updates 🙄 👎

Expected behavior

  • The message about the module having been installed successfully should be an actual success message, instead of a list item.
  • The name of the module should be the human-readable name of the module, instead of the machine name/namespace.
  • "Your projects have been downloaded and updated." is not a step - it should also be a message (or even completely removed?? - we already have another success message there).
  • Do not show the "Run db updates" task if there are no db updates to run - what we should be showing instead is the same options we are showing after successful db updates have run:

Screen Shot 2020-02-09 at 4 01 01 pm

@ghost
Copy link

ghost commented Feb 9, 2020

I can confirm that updating a module with no updates still tries to run the updater as the only option to proceed.

I tested by installing the 'Passphrase policy' module (v1.0.0) and updating it to the latest version (v1.1.3 currently).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant