Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: Drupal 7 upgrade path must include setting for 'Error messages to display'. #4364

Closed
ghost opened this issue Apr 8, 2020 · 6 comments · Fixed by backdrop/backdrop#4013
Closed

Fixed: Drupal 7 upgrade path must include setting for 'Error messages to display'. #4364

ghost opened this issue Apr 8, 2020 · 6 comments · Fixed by backdrop/backdrop#4013
Labels
status - fixed status - has pull request type - bug report
Milestone
1.22.1

Comments

@ghost
Copy link

ghost commented Apr 8, 2020

In D7, the 'Error messages to display' setting (at /admin/config/development/logging) has values of 0, 1 & 2 (for 'None', 'Errors...' & 'All...' respectively). However in Backdrop these values have changed from integers to strings: 'hide', 'some' & 'all' respectively. That means that upgrading from D7 to Backdrop causes this setting to not be defined (at least in the UI):

errors_radios

We should add upgrade code that converts the integer values to the new string values.
@ghost ghost added the type - bug report label Apr 8, 2020
@ghost ghost mentioned this issue Mar 24, 2022
Merged
@ghost
Copy link
Author

ghost commented Mar 24, 2022

PR: backdrop/backdrop#4013

@indigoxela
Copy link
Member

@BWPanda nice catch! Add two more break to your code and I'm happy. 😃

@ghost
Copy link
Author

ghost commented Mar 24, 2022

Done, thanks!

@indigoxela
Copy link
Member

Many thanks for fixing, now this works properly. 👍

@indigoxela indigoxela added this to the 1.21.5 milestone Mar 24, 2022
@ghost ghost modified the milestones: 1.21.5, 1.22.1 May 16, 2022
@indigoxela
Copy link
Member

The code is clear and simple. RTBC!

backdrop-ci referenced this issue in backdrop/backdrop Jul 15, 2022
Issue #4364: Convert Drupal's error level integers to Backdrop's stri…
07a3945 
…ngs during upgrade.

By @BWPanda and @indigoxela.
backdrop-ci referenced this issue in backdrop/backdrop Jul 15, 2022
@quicksketch
Issue #4364: Convert Drupal's error level integers to Backdrop's stri…
fcb38c6 
…ngs during upgrade.

By @BWPanda and @indigoxela.
@quicksketch
Copy link
Member

Thanks @indigoxela and @BWPanda! Merged backdrop/backdrop#4013 into 1.x and 1.22.x.

@jenlampton jenlampton changed the title 'Error messages to display' setting not upgraded from D7 Fixed: Drupal 7 upgrade path must include setting for 'Error messages to display'. Jul 20, 2022
@jenlampton jenlampton mentioned this issue Jul 20, 2022
Closed
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status - fixed status - has pull request type - bug report
Projects
None yet
Milestone
1.22.1
Development

Successfully merging a pull request may close this issue.

Issue #4364: Convert Drupal's error level integers to Backdrop's strings. BWPanda/backdrop
2 participants
@quicksketch @indigoxela