Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments without any fields are still possible to add #4412

Open
nickonom opened this issue May 22, 2020 · 2 comments
Open

Comments without any fields are still possible to add #4412

nickonom opened this issue May 22, 2020 · 2 comments

Comments

@nickonom
Copy link

nickonom commented May 22, 2020

Description of the bug

It's not a bug per se, but a nuance that fails foolproof test. To replicate it, just delete all comment fields, go to the content's page and you can still see the comment form without any fields and you can actually submit it.

backdrop-comment

@indigoxela
Copy link
Member

Comments without any fields... that's an edge case (site builder / admin didn't think 😉 ).

I wonder, where / how we could catch that. And actually: should we catch that? There are for sure several situations where admins can do something not-so-smart...

@nickonom
Copy link
Author

Not sure if it should be dealt with at all, however shouldn't eventually Backdrop CMS' core be stripped of all to-avoid nuances like that? I think the comment form should not be offered to user if there are no any comment fields.

@mikemccaffrey mikemccaffrey mentioned this issue Aug 24, 2020
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants