Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX][D8] Denote which theme has been set as the admin theme #4439

Open
klonos opened this issue Jun 11, 2020 · 2 comments · May be fixed by backdrop/backdrop#3166
Open

[UX][D8] Denote which theme has been set as the admin theme #4439

klonos opened this issue Jun 11, 2020 · 2 comments · May be fixed by backdrop/backdrop#3166

Comments

@klonos
Copy link
Member

klonos commented Jun 11, 2020

We denote which one has been set as the default theme:

Screen Shot 2020-06-11 at 9 45 07 pm

We should also denote which one is the admin theme, same as D8/9:

Screen Shot 2020-06-11 at 9 47 18 pm

@klonos
Copy link
Member Author

klonos commented Jun 11, 2020

PR up for review: backdrop/backdrop#3166

PS: I've also left a comment about this in the PR: I would like some feedback on whether we should do it, plus if it should be done here or a separate issue. I would like to have the is_default and is_admin properties be available in the theme objects returned by system_rebuild_theme_data() and/or list_themes().

@indigoxela
Copy link
Member

Is this still relevant? In a way this seems a duplicate of - or at least it's overlapping with #3617

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants