Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[META] Fix references to "post" or "posts" when we actually mean any content type, or meant to say "create" #4568

Open
klonos opened this issue Aug 23, 2020 · 6 comments · May be fixed by backdrop/backdrop#3262

Comments

@klonos
Copy link
Member

klonos commented Aug 23, 2020

This is a follow-up to #3799

While that issue focused on the text shown in the admin UI on the content type configuration form (/admin/structure/types/manage/page), I've found several places where this is happening, both in user-facing text, as well as inline code comments etc.

Let's fix as many of those as possible.

@klonos klonos changed the title Content referred to as 'post' regardless of content type - take 2 Fix references to 'post' when we actually mean any content type Aug 23, 2020
@klonos klonos changed the title Fix references to 'post' when we actually mean any content type Fix references to "post" or "posts" when we actually mean any content type Aug 23, 2020
@klonos klonos changed the title Fix references to "post" or "posts" when we actually mean any content type [META] Fix references to "post" or "posts" when we actually mean any content type Aug 23, 2020
@klonos
Copy link
Member Author

klonos commented Aug 23, 2020

...I expect this to take multiple iterations, so making it a meta-issue.

@klonos klonos changed the title [META] Fix references to "post" or "posts" when we actually mean any content type [META] Fix references to "post" or "posts" when we actually mean any content type, or meant to say "create" Aug 23, 2020
@klonos
Copy link
Member Author

klonos commented Aug 23, 2020

I've filed a PR that fixes instances of "post date", such as here:

image

PS: when going through views code, my eyes hurt from all the coding standards violations for inline comments, but I refrained from changing them in this PR.

@stpaultim
Copy link
Member

stpaultim commented Aug 24, 2020

Is this helpful?

I found these while testing your PR.

Test__Comment____PR_3262_backdrop_backdrop_testing_site

@klonos
Copy link
Member Author

klonos commented Aug 24, 2020

Thanks @stpaultim 👍 ...I've updated the PR to fix instances of "posted", and some neighbouring instances of "node".

PS: The files the PR was touching increased from 8 to 22, and I would like to keep these changes reviewable. So if there are any more things to be fixed, lets please file separate PRs for them.

@olafgrabienski
Copy link

I've updated the PR to fix instances of "posted"

We shouldn't 'fix' all instances of the verb "to post". To "post" a comment is just fine, language-wise. Sure, it's possible to choose other terms like to "add", or to "create", but it doesn't always sound suitable to me.

What do native speakers think?

@ghost
Copy link

ghost commented Jun 2, 2022

I agree with @olafgrabienski in that 'post' as a verb for creating comments is fine. Trying to change that just makes it awkward. Requesting PR be updated to remove changes related to posting comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants