Simpletest file test adding needless slashes to base path.

[bradbulger]

The base path always begins and ends with a slash ('/'). The Simpletest file test code adds slashes to base_path() that aren't needed, so it ends up creating and looking for paths like "//path/to/my/backdrop//core/misc/favicon.ico".

This is marginally a bug since the test is meeting its own expectations, but still.

[jlfranklin]

There is a bug here, but it's not the double-slash at the beginning. The test claims to be testing protocol-relative URLs, such as //example.org/index.html. This kind of URL says "use the same protocol, http or https, as the current page when connecting to example.org."

But, base_path() returns everything after the hostname. The test should figure out the test site's hostname and include it in the URL.

[bradbulger]

so it should be the base URL minus the protocol? //my.server/path/to/backdrop/admin vs //path/to/backdrop/admin ?

[bradbulger]

In old issues from Drupal like #777830 they refer to paths like "//files/image.jpg" as protocol-relative, but the external documents they link to match the Wikipedia definition that you linked, "//my.server/files/image.jpg". I guess that's where we got it?

[bradbulger]

I updated the PR to fix the constructed protocol-relative URLs. Should the tests be doing a backdropGet() to confirm those URLs actually work?

[bradbulger]

Shouldn't saying "fixes [link to issue]" in the first comment of the PR make it link to this issue?

[gitressa]

I am also puzzled, the syntax looks correct in your PR backdrop/backdrop#336 yet it says "Development - No branches or pull requests" here ...

[gitressa]

Maybe try closing and reopening the PR? (I got the idea from @stpaultim in backdrop/backdrop#3333 (comment)).