[UX] Use the human-readable name of the role in the "role deleted" message

[klonos]

While working on #3813, I've noticed that the machine name of the role is shown in the message:

[klonos]

PR up for review/testing: backdrop/backdrop#3429

[indigoxela]

I've noticed that the machine name of the role is shown in the message

Indeed, confirmed on a 1.17.4 install.

I did a quick check in the Tugboat sandbox and can confirm that the human readable string is shown now, when a role has been deleted. Works as expected.

[indigoxela]

Oops, almost, one test is still failing:

FAIL: The role has been deleted | Other | user.test | 2193 | UserRoleAdminTestCase->testRoleAdministration()

It's not a random failure, it also fails when run via UI in the sandbox.

[indigoxela]

Nope, you already fixed that. Seems that Zen.CI/Tugboat didn't pick up the latest changes? Turn it off and on again?

[klonos]

Meh, twasn't ZenCI ...it needed a strip_tags() in assertText() (because of the <em> around the role name) ...but then ZenCI did start misbehaving ...so I did turn it off and then on again ...multiple times, and now tests are green 👍 ...FINALLY!

[indigoxela]

it needed a strip_tags() in assertText() (because of the <em>...

Right, % wraps the string in <em>, didn't check that. You could also use assertRaw() and then with markup, but strip_tags() also works.

[indigoxela]

Code looks good, RTBC.

[quicksketch]

I think there's an issue with calling check_plain() in the save function will cause double-encoding. I posted a review to the PR: backdrop/backdrop#3429 (review)

[indigoxela]

Sadly, the related PR now has conflicts and changes have been requested, anyway.

As it got no updates since Dec. 2020 it seems stalled. Removing milestone.