Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Move updates settings under the new consolidated "System updates" page #5084

Open
klonos opened this issue May 9, 2021 · 4 comments · May be fixed by backdrop/backdrop#3622
Open

[UX] Move updates settings under the new consolidated "System updates" page #5084

klonos opened this issue May 9, 2021 · 4 comments · May be fixed by backdrop/backdrop#3622

Comments

@klonos
Copy link
Member

klonos commented May 9, 2021

With #2714 we now have a unified page where people can check for and perform updates, under Configuration -> System -> System updates (admin/config/system/updates). Settings for these updates though are still located under Reports -> Updates -> Settings (admin/reports/updates/settings).

I think that no settings page should be under "Reports" (the updates settings page is the only one currently where this happens), so I propose that we move the updates settings page under Configuration -> System -> System updates -> Settings (admin/config/system/updates/settings) instead. In general, it makes sense to configure settings under the same place where the thing the settings apply to lives.

@klonos
Copy link
Member Author

klonos commented May 9, 2021

Hmm 🤔 ...apparently this would require the Installer module to be responsible for the updates settings page, whereas now the Update module is responsible for it (as well as the "Available updates" report).

@klonos
Copy link
Member Author

klonos commented May 9, 2021

...well not entirely true. The "Check for available updates" and "Update Notifications" sections under admin/reports/updates/settings hold settings relevant to the Update module, whereas the "Self-updates" section holds settings for the Installer module 🤔 🤔 🤔

@klonos
Copy link
Member Author

klonos commented May 12, 2021

PR up for review: backdrop/backdrop#3622

The "Self-updates" fieldset from admin/reports/updates/settings is now moved under a new admin/config/system/updates/settings form:

image

Now these 2 forms save settings that belong to the respective module.

@jenlampton
Copy link
Member

jenlampton commented May 16, 2021

@klonos I don't think this is an improvement. As a user, I don't want to have my "Update settings" spread across two different forms. I don't care which module is responsible for which values, it's far easier to only need to find one obscure location to enter my settings.

I went through this same thought process as I was testing the consolidated update pages. I also dislike that there are any settings in the "Reports" section at all, but I still think having all Update settings in once place is better than two places. And since people already know it's in a weird place, might as well leave them there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment