[UX] Oddities with the "Number of posts on home page" setting in admin/config/system/site-information

[klonos]

Steps To Reproduce

1. Go to admin/config/system/site-information
2. Change the home page path to node -> notice that no additional option is shown.
3. Save the settings -> the "Number of posts on home page" option is shown in the "Home page" fieldset 👎🏼 (should have shown up in the previous step)
4. Change the home page path to home (or blank, or something else) -> notice that the "Number of posts on home page" option is still shown 👎🏼
5. Save the form -> the "Number of posts on home page" option is gone 👎🏼 (should have been hidden the moment the path was such that it was not applicable any longer)

Actual behavior

You need to save the form for the "Number of posts on home page" option to be shown/hidden.

Expected behavior

The "Number of posts on home page" option is shown/hidden using #states.

Bonus

The help text for the "Number of posts on home page" option is:

The maximum number of posts displayed on overview pages such as the home page.

That text reads odd, and has a few inaccuracies:

• the content types displayed may be other than just posts
• this setting actually controls the number of pieces of content shown per page (in the Views pager that is created)
• "such as the home page"??? ...but this setting here IS for the home page

[klonos]

This is D7 carry-over that we cannot remove yet, until terms are also provided by Views (see #145), since this accounts for that as well (the words "overview pages" in the help text seem to be there because of that).

We've contemplated on this with @docwilmot and @jenlampton during the sprint for the 1.21.0 release last night, and decided that we'd be better off if this entire setting was removed from this place, and was instead exposed in the settings for the "Promoted content" block (because we now have #2433).

[indigoxela]

Isn't that a duplicate of #1628?

[klonos]

Related or a "partial alternative" perhaps, but not duplicate @indigoxela. Lots have changed since 2016, and certain of the things are less problematic or non-issues now. So I would have to revisit/revise #1628 (perhaps even close off?).

[indigoxela]

So I would have to revisit/revise #1628 (perhaps even close off?).

I'd suggest to close the old one, as it's for sure pretty outdated.

[klonos]

I'd suggest to close the old one...

Thanks. I've done that + added a comment to explain why.

[ghost]

I previously brought this up here: #3343 (comment)

[klonos]

I just confirmed that the "Number of posts on home page" setting worked in D7 the same way as it does in Backdrop: if the actual number of promoted nodes is bigger than that setting, the it adds a listing with a pager, which allows you to navigate to the rest of the promoted nodes.

PR: backdrop/backdrop#3897