[UX] Fixed: Time picker in Date Pop-up calendar does not respect time format.

[yorkshire-pudding]

Description of the bug

Firstly, an AM/PM is shown when time is set to use G for hour (i.e. 24 hour with no leading zeroes). In #4064 @VasasA proposed a solution which works:
On
https://github.com/backdrop/backdrop/blob/8ce893d89106993c37ada5339355c9ead03bb8e8/core/modules/date/date.elements.inc#L1170

Change:

      'show24Hours' => strpos($element['#date_format'], 'H') !== FALSE ? TRUE : FALSE,

to:

'show24Hours' => (strpos($element['#date_format'], 'H') !== FALSE || strpos($element['#date_format'], 'G') !== FALSE) ? TRUE : FALSE,

but because the other issue in the ticket (dot after date) could not be solved, this has not been implemented.

Secondly, the tooltip has a time that doesn't respect the time format, e.g. 04:34PM and 05:34PM

I cannot work out where this is coming from.
Is Chrome autofill

Steps To Reproduce

To reproduce the behavior:

1. Add a date field to content type
2. Pick a date time format with G for time format
3. Create a content and click into the time field

Actual behavior

Only 12 hour clock can be entered and PM is shown after
Tooltip shows in 12 hour format

Expected behavior

24 hour time can be entered
Tooltip respects the time format

Additional information

Add any other information that could help, such as:

• Backdrop CMS version: 1.22.2
• Web server and its version: litespeed
• Operating System and its version: n/a
• Browser(s) and their versions: Chrome 103

[yorkshire-pudding]

I've added a PR that addresses this the first part. Credit for this should go to @VasasA . However, I cannot work out how to fix the tooltip, if that is too hard, we should go ahead with the PR as it stands

[indigoxela]

I've never seen a time tooltip on core date fields (with datepicker enabled). How do I have to setup the widget to get one?

Edit: ah, it ships with the module? 😀

[yorkshire-pudding]

Did you find where it is? Does that mean its possible to disable it?

[indigoxela]

Did you find where it is?

No... reading the core code - it should be there OOTB, right? Never saw one. Also not on D7...

Please enlighten me! 💡

[yorkshire-pudding]

I don't know. I'll try in a different browser

[indigoxela]

I tried in FF and Chrome on Linux. The script is loaded, but I never saw any time popup (tooltip).

[yorkshire-pudding]

Was a Chrome autofill. It must have added whilst I was testing before I fixed the format.

[indigoxela]

Nevertheless, G should still lead to a 24 hour format - which it currently doesn't (confirmed).

But... even with the patch applied, the format still has leading zeros. Probably because the datepicker widget is a bit opinionated when it comes to input formats.

[yorkshire-pudding]

Yes, I couldn't find anywhere to change that, but it didn't bother me as much as not being able to enter 24 hour time. If there is a simple way to force it to use the format, then great, but if not, in my opinion, it shouldn't stop the 24 hour fix going in.

[yorkshire-pudding]

😄 all automated tests have passed ✔️

[indigoxela]

Seems like we agree, that the 24-hour format problem should get fixed - no matter if the leading zeros are there or not.

It works for me. 👍

[herbdool]

Looks good to me!

[quicksketch]

Merged into 1.x and 1.22.x. Thanks folks!