Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log completely unusable when an entry has corrupt serialized data. #5761

Closed
klonos opened this issue Sep 5, 2022 · 3 comments · Fixed by backdrop/backdrop#4190
Closed

Log completely unusable when an entry has corrupt serialized data. #5761

klonos opened this issue Sep 5, 2022 · 3 comments · Fixed by backdrop/backdrop#4190

Comments

@klonos
Copy link
Member

klonos commented Sep 5, 2022

This is to crossport https://www.drupal.org/project/drupal/issues/2790857, which was recently committed to D7 core:

If an entry in the dblog has corrupt serialized data, the dblog page (/admin/reports/dblog) will throw an exception and will not load.

If unserialize fails, then a boolean is sent to t() leading to a fatal exception.
$output = t($event->message, unserialize($event->variables));

@indigoxela
Copy link
Member

indigoxela commented Sep 5, 2022

Fancy, I never ran into this before, but I can confirm that Backdrop is also affected.

I created a dump for a watchdog table and edited one of the records to make the "variables" column content unusable (added some random characters). After importing and going to /admin/reports/dblog I get:

broken-watchdog

Then applied the patch and went back to /admin/reports/dblog - and the page works again. The broken entry doesn't show up anymore.

@bugfolder
Copy link

Code reviewed, LGTM.

@bugfolder bugfolder added this to the 1.26.1 milestone Sep 17, 2023
@quicksketch quicksketch modified the milestones: 1.26.1, 1.26.2 Oct 6, 2023
backdrop-ci referenced this issue in backdrop/backdrop Oct 9, 2023
…ized data.

By @klonos, @indigoxela, and @bugfolder.

Port of Druppal issue #2790857 by poker10, dalin, richardcanoe, mcdruid, yogeshmpawar, Rishi Kulshreshtha.
backdrop-ci referenced this issue in backdrop/backdrop Oct 9, 2023
…ized data.

By @klonos, @indigoxela, and @bugfolder.

Port of Druppal issue #2790857 by poker10, dalin, richardcanoe, mcdruid, yogeshmpawar, Rishi Kulshreshtha.
@quicksketch
Copy link
Member

Thanks for reviewing this @bugfolder! Looks like a good port from Drupal 7. I merged backdrop/backdrop#4190 into 1.x and 1.26.x. Thanks @klonos and @indigoxela for the PR and testing!

@klonos klonos removed their assignment Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants