Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX] No summary in the "Region and Language" vtab in the account edit form #5900

Closed
klonos opened this issue Dec 31, 2022 · 4 comments · Fixed by backdrop/backdrop#4291
Closed

[UX] No summary in the "Region and Language" vtab in the account edit form #5900

klonos opened this issue Dec 31, 2022 · 4 comments · Fixed by backdrop/backdrop#4291
Labels
status - fixed status - has pull request type - bug report
Milestone
1.26.2

Comments

@klonos
Copy link
Member

klonos commented Dec 31, 2022

Noticed this while working on #5899:

image
@klonos klonos self-assigned this Dec 31, 2022
@klonos klonos mentioned this issue Dec 31, 2022
Merged
@klonos
Copy link
Member Author

klonos commented Dec 31, 2022

PR up for review: backdrop/backdrop#4291

image

@olafgrabienski
Copy link

Good catch, @klonos. I was able to reproduce the issue and tested the fix in the PR sandbox, works for me!

@bugfolder
Copy link

Nice fix. Code reviewed, LGTM.

@bugfolder bugfolder added this to the 1.26.1 milestone Sep 18, 2023
@quicksketch quicksketch modified the milestones: 1.26.1, 1.26.2 Oct 6, 2023
backdrop-ci referenced this issue in backdrop/backdrop Oct 9, 2023
@klonos
Issue #5900: Fix summary text for Region and Language vertical tab.
9a8ee03 
By @klonos, @olafgrabienski, and @bugfolder.
backdrop-ci referenced this issue in backdrop/backdrop Oct 9, 2023
@klonos @quicksketch
Issue #5900: Fix summary text for Region and Language vertical tab.
f9e38c4 
By @klonos, @olafgrabienski, and @bugfolder.
@quicksketch
Copy link
Member

Thanks folks! I merged backdrop/backdrop#4291 into 1.x and 1.26.x.

@klonos klonos removed their assignment Oct 11, 2023
@quicksketch quicksketch mentioned this issue Dec 1, 2023
Closed
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status - fixed status - has pull request type - bug report
Projects
None yet
Milestone
1.26.2
Development

Successfully merging a pull request may close this issue.

Issue #5900: Fix summary text for Region and language vtab klonos/backdrop
4 participants
@quicksketch @klonos @olafgrabienski @bugfolder