Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Create a separate section for the 2 default layouts in the layout management page #5934

Closed
klonos opened this issue Jan 15, 2023 · 7 comments · Fixed by backdrop/backdrop#4313

Comments

@klonos
Copy link
Member

klonos commented Jan 15, 2023

This is a follow-up to #5077 and related to #4871.

The default and admin_default layouts are a special case: fallback layouts that are used when no other layout applies. However, we are listing them along with the rest of the layouts that belong in the "Layout overrides" section.

I think that these deserve a special place, especially since:

  • they are already being rendered last in the list - regardless of weight/alpha
  • they already have a separate "group description": Default layouts (used on all paths without a specific layout)

I'm basically suggesting to split this subsection of the layout overrides table into it's own table:
image

@klonos
Copy link
Member Author

klonos commented Jan 15, 2023

PR up for review and feedback: backdrop/backdrop#4313

@bugfolder
Copy link

bugfolder commented Sep 10, 2023

Since this was marked "needs - more feedback," I'll give the feedback that I think this is a great change that improves clarity.

Since it's been around for 9 months, there are two more thumbs up, and no negative feedback, I'm going to remove the "needs more feedback" label.

One small formatting issue in the code, noted in the PR.

Tested, WFM. Code will be LGTM when the PR is updated.

@stpaultim
Copy link
Member

I support this change. @klonos it sounds like this one is very close.

@bugfolder
Copy link

@klonos it sounds like this one is very close.

Yes, one tiny formatting suggestion in the PR.

@klonos
Copy link
Member Author

klonos commented Dec 1, 2023

The PR had conflicts. I've fixed those (which also rebased the PR branch) and have also merged @bugfolder's code suggestion 👍🏼

All tests are green too 🎉 (no layout test gremlins for some odd reason 🤷🏼 ...have they gone away in the same mysterious way they came? 🤞🏼 ).

@bugfolder
Copy link

Tested, WFM.

Code re-reviewed, LGTM.

RTBC. 🎉🎉🎉

@quicksketch
Copy link
Member

Thanks this is a wonderful little improvement! It makes a ton of sense to separate out the default layouts from the others. I merged backdrop/backdrop#4313 into 1.x and 1.26.x. Thanks @klonos and @bugfolder!

@klonos klonos removed their assignment Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants