Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Views: "You may also adjust the settings for the currently selected row style" is confusing/problematic #5993

Open
klonos opened this issue Feb 22, 2023 · 0 comments

Comments

@klonos
Copy link
Member

klonos commented Feb 22, 2023

Description of the bug

This help text is available in the "Settings" dialog when you are configuring the row style in Views:

You may also adjust the settings for the currently selected row style.

image

If JavaScript is disabled, then the page at admin/structure/views/nojs/display/%view_name%/%display_name%/row_plugin opens instead of the popup dialog.

Steps To Reproduce

Consider this use case:

  1. Create a new view using the wizard at admin/structure/views/add.
  2. Give it any name, and leave all options to their defaults.
  3. Click on "Continue and configure"
  4. In the "FORMAT" section, click the "Content" link.
  5. In the dialog (or page if you have JS disabled) that opens, select the "Fields" option
  6. Notice the help text, and click on the "settings" link (without clicking the "Apply" button).

Actual behavior

  • While you had selected "Fields", clicking on the "settings" link takes you to the settings for the "Content" option 👎🏼
  • Clicking the link takes you away from the form, and although not that bad (there's only 2 options in the form), you still lost your edit. The settings form does not have a similar link to take you back to what you were doing - you now need to close the dialog without saving, and click on the "Content" link again 👎🏼

Expected behavior

Since the help text tells you that you can configure the settings for the "currently selected" row style, you'd expect to see the settings for whatever option you had selected from the radio set - NOT the "currently configured" row style.

Additional information

  • We could change the help text to say "currently configured" instead of "currently selected". That still seems like a confusing workflow still though.
  • We could remove the help text with that link altogether, since clicking the "Apply" button on the dialog will take you to the settings page of whatever option you have selected.
  • We could consider moving the settings in the same dialog as when you are selecting the row style (into a fieldset perhaps). Then we could use #states or AJAX, to load the appropriate settings, depending on which option is selected. There would only be a single form submission required.
  • We could consider adding a "Settings" horizontal tab in the dialog/page. In the page (when no JS is enabled) that would be a regular horizontal tab, whereas in the dialog it would be similar to the tabs we have in the image upload dialog:
    image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant