FAPI element type password_confirm wipes out all preset attributes from the form element

[argiepiano]

Description of the bug

When creating a form that uses the Form API type password_confirm, all custom #attributes included in the form element definition are removed/ignored.

Steps To Reproduce

To reproduce the behavior:

1. Create a form callback function that includes a password_confirm element AND contains a custom attribute such as data-important-stuff:

  $form['password'] = array(
    '#type' => 'password_confirm',
    '#title' => 'Password',
    '#maxlength' => 64,
    '#size' => 15,
    '#attributes' => array(
      'data-important-stuff' => 'important-data-goes-here',
    ),
  );
  return $form;

2. Inspect the rendered output. Notice that the data-important-stuff attribute is not included

Actual behavior

Custom attributes for the element are removed/not rendered.

Expected behavior

The form element should include the custom attributes.

Additional information

• Backdrop CMS version: 1.25.1
• PHP version: 8.1
• Browser(s) and their versions: Chrome

---

PR backdrop/backdrop#4467

[argiepiano]

PR backdrop/backdrop#4467 ready for review and testing. To test, you can use the example I pasted in the OP.

[argiepiano]

Test failure in PHP 5 seems unrelated to the PR.

[kiamlaluno]

It is the test for enabling/disabling modules that fails. I have seen that failure in another PR; it's a random failure which is indeed not related to the PR.

[argiepiano]

Here's a tiny module to generate that form (for testing).
testing_stuff.zip

[klonos]

Tried to close/reopen the PR multiple times in order to get the tests to pass green, however there seems to be an issue with tugboat sandboxes at the moment, and I am also getting the "Start and end date ..." know random failure. I'll try again in later.

Code looks good to me though 👍🏼

[indigoxela]

@argiepiano many thanks for your PR. 🙏 I've left a question there.

[bugfolder]

Tested (with the provided test module) and confirmed that it works. Closed and reopened the PR, and all tests are running and passing (even though we're getting the Tugboat-over-quota message; presume that tests are running on the old Tugboat instance.) LGTM, WFM.

[quicksketch]

Thanks @argiepiano, @klonos, @bugfolder, @kiamlaluno, and @indigoxela! I've merged backdrop/backdrop#4467 into 1.x and 1.25.x.