-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User name views autocomplete filter always shows the same description #6170
Comments
@olafgrabienski thanks for the response. That view uses a different handler, one that doesn't provide auto complete. It's an acceptable alternative to this bug. There are two name filter handlers. The one you mentioned is called 'raw' |
Ah, got it! Tried again with autocomplete, and yes, issue confirmed. |
It makes sense to me, that this field description (help text) gets handled like other ones, when exposed. The other fields allow to set a custom text or leave empty. I verified the behavior, then applied the patch and verified that only my custom description is visible (empty if not set). So the field aligns with others, when exposed. Works for me. 👍 |
Code reviewed. LGTM. |
Thanks @argiepiano, @indigoxela, @olafgrabienski, and @bugfolder! I've merged backdrop/backdrop#4473 into 1.x and 1.26.x. |
Description of the bug
Even if the description for the user name exposed filter is left blank, the following is shown:
This makes it impossible to customize the description for this filter, plus it causes quite a bit of alignment problems in Seven if the other filters don't contain descriptions.
There is a D7 issue for this.
Steps To Reproduce
Actual behavior
The description for the user name is shown.
Expected behavior
If left blank no description should be shown. And if the description is customized, that customization should be shown verbatim.
Additional information
Add any other information that could help, such as:
PR backdrop/backdrop#4473
The text was updated successfully, but these errors were encountered: