Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User name views autocomplete filter always shows the same description #6170

Closed
argiepiano opened this issue Jul 14, 2023 · 7 comments · Fixed by backdrop/backdrop#4473
Closed

Comments

@argiepiano
Copy link

argiepiano commented Jul 14, 2023

Description of the bug

Even if the description for the user name exposed filter is left blank, the following is shown:

Screen Shot 2023-07-14 at 7 30 06 AM

This makes it impossible to customize the description for this filter, plus it causes quite a bit of alignment problems in Seven if the other filters don't contain descriptions.

There is a D7 issue for this.

Steps To Reproduce

  1. Create a user View
  2. Add a user name exposed filter, leave the description blank
  3. Add another exposed filter without a description
  4. Visit the view

Actual behavior

The description for the user name is shown.

Expected behavior

If left blank no description should be shown. And if the description is customized, that customization should be shown verbatim.

Additional information

Add any other information that could help, such as:

  • Backdrop CMS version: 1.25.0

PR backdrop/backdrop#4473

@argiepiano
Copy link
Author

PR backdrop/backdrop#4473

@olafgrabienski
Copy link

olafgrabienski commented Jul 14, 2023

Interesting! Reading your description, the "Manage user accounts" view comes to mind. This view doesn't show the issue, even if it has a user name exposed filter with blank description, as well as another exposed filter without a description.

Is there something missing in the steps to reproduce?

Screenshot:

@argiepiano
Copy link
Author

argiepiano commented Jul 14, 2023

@olafgrabienski thanks for the response. That view uses a different handler, one that doesn't provide auto complete. It's an acceptable alternative to this bug.

There are two name filter handlers. The one you mentioned is called 'raw'

@argiepiano argiepiano changed the title User name views filter always shows the same description User name views autocomplete filter always shows the same description Jul 14, 2023
@olafgrabienski
Copy link

That view uses a different handler, one that doesn't provide auto complete.

Ah, got it! Tried again with autocomplete, and yes, issue confirmed.

@indigoxela
Copy link
Member

It makes sense to me, that this field description (help text) gets handled like other ones, when exposed. The other fields allow to set a custom text or leave empty.

I verified the behavior, then applied the patch and verified that only my custom description is visible (empty if not set). So the field aligns with others, when exposed.
The help text is still there in the views admin form, when configuring the field, of course.

Works for me. 👍

@bugfolder
Copy link

Code reviewed. LGTM.

@quicksketch
Copy link
Member

Thanks @argiepiano, @indigoxela, @olafgrabienski, and @bugfolder! I've merged backdrop/backdrop#4473 into 1.x and 1.26.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants