Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry UI doesn't show the module name as specified #6222

Closed
jenlampton opened this issue Sep 15, 2023 · 1 comment · Fixed by backdrop/backdrop#4516
Closed

Telemetry UI doesn't show the module name as specified #6222

jenlampton opened this issue Sep 15, 2023 · 1 comment · Fixed by backdrop/backdrop#4516

Comments

@jenlampton
Copy link
Member

jenlampton commented Sep 15, 2023

Description of the bug

While working on the telemetry integration for CKEditor, here, I discovered that even if you define a project via the API, it does not appear properly in the telemetry report.

It is supposed to appear in parentheses below the metric name, in the left hand column. Instead, the telemetry label was showing in that location.

Before:
Screenshot 2023-09-14 at 5 05 31 PM

After:
Screenshot 2023-09-14 at 4 59 56 PM

This was likely missed before, because the only projects displayed were in core (and thus showing "System" instead of the project name)

Steps To Reproduce

To reproduce the behavior:

  1. Create a custom module that implements hook_telemetry_info() and hook_telemetry_data()
  2. Visit the telemetry report at admin/reports/telemetry
  3. Confirm your project name does not appear as intended.

Additional information

Please note, the screenshots above are in Bartik because I am also working on #6221 at the same time - that is not related to this issue :)

Add any other information that could help, such as:

  • Backdrop CMS version:
  • Web server and its version:
  • PHP version:
  • Database sever (MySQL or MariaDB?) and its version:
  • Operating System and its version:
  • Browser(s) and their versions:
@quicksketch
Copy link
Member

Oops! A simple mistake to fix though. Thank you! I have merged your PR at backdrop/backdrop#4516 into 1.x and 1.25.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants