Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update label CKEditor to "CKEditor 4" throughout core #6250

Closed
quicksketch opened this issue Oct 5, 2023 · 3 comments · Fixed by backdrop/backdrop#4540
Closed

Update label CKEditor to "CKEditor 4" throughout core #6250

quicksketch opened this issue Oct 5, 2023 · 3 comments · Fixed by backdrop/backdrop#4540

Comments

@quicksketch
Copy link
Member

quicksketch commented Oct 5, 2023

Description of the need

The core module ckeditor should distinguish itself from the contrib module ckeditor5 by using the label "CKEditor 4" wherever possible, including in the status report messages, text editor label, and in the .info file. This will help prevent confusion when there are both CKEditor 4 and 5 modules in core.

@quicksketch
Copy link
Member Author

I filed a PR at backdrop/backdrop#4540. I didn't change every instance of CKEditor to CKEditor 4. I converted the following:

  • Any displayed label or description in the admin interface.
  • Any summary in function docblocks (the first sentence) and in all hooks.
  • At the top of every file in CKEditor 4 module (e.g. css, js, inc files).

I did not update references within extended docblock descriptions (such as parameter descriptions), since it would have been a much larger set of changes re-wrapping all the the docblocks, and redundant when CKEditor can be mentioned 10+ times within a docblock.

@indigoxela
Copy link
Member

@quicksketch This looks great! 👍 Actually ready to go, but phpcs nags, because you previously contributed a lot to the files now changed (git blame in our GHA...).

The actual change seems small enough to add those coding standard fixes, I guess. Or, if you prefer not to mix those in, go ahead and merge. 😉

@quicksketch
Copy link
Member Author

Thanks @indigoxela! I've merged backdrop/backdrop#4540 into 1.x and 1.26.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants