-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update label CKEditor to "CKEditor 4" throughout core #6250
Comments
I filed a PR at backdrop/backdrop#4540. I didn't change every instance of
I did not update references within extended docblock descriptions (such as parameter descriptions), since it would have been a much larger set of changes re-wrapping all the the docblocks, and redundant when CKEditor can be mentioned 10+ times within a docblock. |
@quicksketch This looks great! 👍 Actually ready to go, but phpcs nags, because you previously contributed a lot to the files now changed (git blame in our GHA...). The actual change seems small enough to add those coding standard fixes, I guess. Or, if you prefer not to mix those in, go ahead and merge. 😉 |
Thanks @indigoxela! I've merged backdrop/backdrop#4540 into 1.x and 1.26.x. |
Description of the need
The core module
ckeditor
should distinguish itself from the contrib moduleckeditor5
by using the label "CKEditor 4" wherever possible, including in the status report messages, text editor label, and in the .info file. This will help prevent confusion when there are both CKEditor 4 and 5 modules in core.The text was updated successfully, but these errors were encountered: