Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the documentation comment for field_config_delete() which is a hook_config_delete() implementation #6318

Closed
kiamlaluno opened this issue Dec 3, 2023 · 3 comments · Fixed by backdrop/backdrop#4592
Closed

Correct the documentation comment for field_config_delete() which is a hook_config_delete() implementation #6318

kiamlaluno opened this issue Dec 3, 2023 · 3 comments · Fixed by backdrop/backdrop#4592
Labels
status - fixed status - has pull request type - documentation type - task
Milestone
1.26.4

Comments

@kiamlaluno
Copy link
Member

field_config_delete() has the following documentation comment.

/**
 * Implements hook_config_update().
 */

That documentation comment is not correct, as that function implements hook_config_delete().
@kiamlaluno kiamlaluno changed the title field_config_delete() is documented as field_config_delete() is documented as hook_config_update() implementation Dec 3, 2023
@kiamlaluno kiamlaluno mentioned this issue Dec 3, 2023
Merged
@argiepiano
Copy link

LGTM

@kiamlaluno kiamlaluno changed the title field_config_delete() is documented as hook_config_update() implementation Correct the documentation comment for field_config_delete() which is a hook_config_delete() implementation Dec 24, 2023
@kiamlaluno
Copy link
Member Author

I updated the PR to be synchronized with the main branch.

backdrop-ci referenced this issue in backdrop/backdrop Jan 1, 2024
@kiamlaluno
Issue #6318: field_config_delete() is documented as hook_config_updat…
c4a0beb 
…e() implementation.

By @kiamlaluno and @argiepiano.
backdrop-ci referenced this issue in backdrop/backdrop Jan 1, 2024
@kiamlaluno @quicksketch
Issue #6318: field_config_delete() is documented as hook_config_updat…
0fe7f9b 
…e() implementation.

By @kiamlaluno and @argiepiano.
@quicksketch
Copy link
Member

Thanks @kiamlaluno and @argiepiano! Merged backdrop/backdrop#4592 into 1.x and 1.26.x.

@quicksketch quicksketch added this to the 1.26.4 milestone Jan 1, 2024
@quicksketch quicksketch mentioned this issue Jan 16, 2024
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status - fixed status - has pull request type - documentation type - task
Projects
None yet
Milestone
1.26.4
3 participants
@kiamlaluno @quicksketch @argiepiano