Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy hook from Testing module. #6350

Closed
kiamlaluno opened this issue Dec 30, 2023 · 4 comments · Fixed by backdrop/backdrop#4624
Closed

Remove legacy hook from Testing module. #6350

kiamlaluno opened this issue Dec 30, 2023 · 4 comments · Fixed by backdrop/backdrop#4624

Comments

@kiamlaluno
Copy link
Member

simpletest_registry_files_alter() is a hook_registry_files_alter() implementation Backdrop core does not invoke anymore, since the class registry and its hooks has been replaced by hook_autoload_info() and hook_autoload_info_alter().

simpletest_registry_files_alter() is supposed to add test files for disabled modules. If that is necessary, a different hook must be used; otherwise, that function can simply be removed.

@kiamlaluno
Copy link
Member Author

The only failure is caused by the layout_load_multiple_by_path() function which is not found.

@herbdool
Copy link

@kiamlaluno while you're at it, can you also update the comment for simpletest_test_get_all()? It also mentions that same missing hook.

@kiamlaluno
Copy link
Member Author

I also updated the PR as per the recent commits.

@quicksketch
Copy link
Member

Excellent, thank you @kiamlaluno and @herbdool! Merged backdrop/backdrop#4624 into 1.x and 1.27.x.

@jenlampton jenlampton changed the title The Testing module implements a hook that is not invoked by Backdrop Fixed: Remove legacy hook from Testing module. Mar 8, 2024
@jenlampton jenlampton changed the title Fixed: Remove legacy hook from Testing module. Remove legacy hook from Testing module. Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants