Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "cketoolbar" config key to just "toolbar" #6352

Closed
Tracked by #4122
quicksketch opened this issue Jan 2, 2024 · 4 comments · Fixed by backdrop/backdrop#4625
Closed
Tracked by #4122

Rename "cketoolbar" config key to just "toolbar" #6352

quicksketch opened this issue Jan 2, 2024 · 4 comments · Fixed by backdrop/backdrop#4625
Labels
status - fixed status - has pull request type - task
Milestone
1.27.0

Comments

@quicksketch
Copy link
Member

Follow up to #4122.

In the CKEditor Contrib module, we renamed the config key used by CKEditor 5 within text format settings from "cketoolbar" to just "toolbar" in issue backdrop-contrib/ckeditor5#113. This was to work around a core bug that was fixed in Backdrop 1.26.3.

We should make this change in core as well now that we no longer have to work-around the core bug from #6203.
@quicksketch quicksketch added this to the 1.27.0 milestone Jan 2, 2024
This was referenced Jan 2, 2024
Closed
Merged
@quicksketch
Copy link
Member Author

PR filed at backdrop/backdrop#4625 that ports the change from the contrib module.

@quicksketch
Copy link
Member Author

I updated my PR at backdrop/backdrop#4625 based on @indigoxela's feedback (thank you!).

@indigoxela
Copy link
Member

@quicksketch many thanks for the update, this works properly now. 👍

backdrop-ci referenced this issue in backdrop/backdrop Jan 4, 2024
@quicksketch
Issue #6352: Update 'cketoolbar' config key to just 'toolbar'.
404c61d 
By @quicksketch and @indigoxela.
@quicksketch
Copy link
Member Author

Thanks @indigoxela! We didn't get this into 1.27.0-preview but it will be in the final release.

@quicksketch quicksketch mentioned this issue Jan 16, 2024
Open
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status - fixed status - has pull request type - task
Projects
None yet
Milestone
1.27.0
Development

Successfully merging a pull request may close this issue.

Issue #6352: Update 'cketoolbar' config key to just 'toolbar'. quicksketch/backdrop
2 participants
@quicksketch @indigoxela