Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Views "Add fields" dialog: top/bottom borders missing from the footer divs (.views-add-form-selected and .ui-dialog-buttonpane) #6545

Open
klonos opened this issue May 15, 2024 · 1 comment · May be fixed by backdrop/backdrop#4752
Open

Views "Add fields" dialog: top/bottom borders missing from the footer divs (.views-add-form-selected and .ui-dialog-buttonpane) #6545

klonos opened this issue May 15, 2024 · 1 comment · May be fixed by backdrop/backdrop#4752
Assignees
@klonos
Labels
pr - needs code review pr - needs testing status - has pull request type - bug report
Milestone
1.28.1

Comments

@klonos
Copy link
Member

klonos commented May 15, 2024 •
edited

I noticed this while trying to figure out the problem behind #6395. Here's a couple of before/after screenshots:

  • w/o any field selected in the dialog:
    image
  • field selected:
    image

The respective bottom border exists in the "header" div of the dialog:
image
@klonos klonos self-assigned this May 15, 2024
This was referenced May 15, 2024
Open
Open
@klonos klonos added this to the 1.27.2 milestone May 15, 2024
@klonos klonos changed the title Views "Add fields" dialog: top/bottom borders missing from the bottom divs (.views-add-form-selected and .ui-dialog-buttonpane) Views "Add fields" dialog: top/bottom borders missing from the footer divs (.views-add-form-selected and .ui-dialog-buttonpane) May 15, 2024
@klonos
Copy link
Member Author

klonos commented May 15, 2024

PR here: backdrop/backdrop#4752

@jenlampton jenlampton modified the milestones: 1.27.2, 1.28.1 May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@klonos klonos

Labels
pr - needs code review pr - needs testing status - has pull request type - bug report
Projects
None yet
Milestone
1.28.1
Development

Successfully merging a pull request may close this issue.

Issue #6545: Views: Add top-bottom border in the footer of the 'Add fields' dialog klonos/backdrop
2 participants
@jenlampton @klonos