You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm using the workflow and wokflow_node modules and have hit a bug in https://github.com/backdrop-contrib/workflow/blob/1.x-2.x/workflow_node/workflownode.tokens.inc#L73. That code calls system_get_date_types to generate some tokens based on the available date formats. Currently, it will throw a TypeError: Cannot access offset of type string on string in workflownode_token_info(). Looking into system_get_date_types(), it looks to me like the conditional logic for checking for whether we're looking for a specific $type or not is flipped and so additional array keys with empty values are getting added to the $formats array if no $type argument is used.
Steps To Reproduce
Enable the workflow and workflow_node modules and the error should be immediately triggered.
I'll be submitting PR shortly for review.
The text was updated successfully, but these errors were encountered:
I got the results as expected (I think? ...there's an array with info about all date formats on the site), but also these two warnings:
Warning: Undefined array key "name" in system_get_date_types() (line 2571 of /var/lib/tugboat/backdrop/core/includes/drupal.inc).
Warning: Undefined array key "label" in system_get_date_types() (line 2572 of /var/lib/tugboat/backdrop/core/includes/drupal.inc).
I'll need to also test things with adding custom date formats (other then those provided OOTB with core) + also compare the same with the changes proposed in the PR.
Thanks again for the PR @anemirovsky. I'll loop back to this to do proper review/testing as soon as possible.
Description of the bug
I'm using the
workflow
andwokflow_node
modules and have hit a bug in https://github.com/backdrop-contrib/workflow/blob/1.x-2.x/workflow_node/workflownode.tokens.inc#L73. That code callssystem_get_date_types
to generate some tokens based on the available date formats. Currently, it will throw aTypeError: Cannot access offset of type string on string in workflownode_token_info()
. Looking intosystem_get_date_types()
, it looks to me like the conditional logic for checking for whether we're looking for a specific$type
or not is flipped and so additional array keys with empty values are getting added to the$formats
array if no$type
argument is used.Steps To Reproduce
Enable the
workflow
andworkflow_node
modules and the error should be immediately triggered.I'll be submitting PR shortly for review.
The text was updated successfully, but these errors were encountered: