Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config: incorrect warning thrown when no files are found in import #667

Open
jenlampton opened this issue Jan 31, 2015 · 3 comments
Open

Comments

@jenlampton
Copy link
Member

A spin off from #661 (comment)

If no files are found during a config import, we should throw a warning specifying that no files are found. Right now we instead throw the incorrect warning:
The uploaded configuration matches the current site configuration exactly. No changes were made.

This implies that files were found, comparisons were made, and it was determined that the imported files match the config exactly. But that's not at all what's actually happening :)

@serundeputy
Copy link
Member

is this referring to here:
/admin/config/development/configuration/full -- I get: '' no message, no error.
here:
/admin/config/development/configuration/single -- I get: 'Paste your configuration here field is required.'

is this issue referring to another form?

@quicksketch
Copy link
Member

I think @jenlampton meant that she gets this error when uploading a .tar.gz file that doesn't contain any config files. So if you actually upload a file but it doesn't contain any files you'll get the inaccurate message saying the uploaded config is "identical" rather than just nothing found.

@serundeputy
Copy link
Member

I took a look at this. It is in this file:
core/modules/config/config.admin.inc

Actually detecting that the uploaded tgz is empty or does not contain a valid config file is a bit over my head.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants