Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DX] move system_admin_bar_cache_info() into update.module #804

Closed
jenlampton opened this issue Mar 6, 2015 · 4 comments
Closed

[DX] move system_admin_bar_cache_info() into update.module #804

jenlampton opened this issue Mar 6, 2015 · 4 comments
Labels
status - fixed status - has pull request type - task
Milestone
1.11.0

Comments

@jenlampton
Copy link
Member

jenlampton commented Mar 6, 2015 •
edited by klonos
Loading

left-over cleanup from moving admin_menu/admin_bar into core. update_admin_bar_cache_info() is in admin_bar.inc instead of in update.module.

Let's move this function.

PR by @docwilmot: backdrop/backdrop#2212
@Graham-72 Graham-72 mentioned this issue Apr 1, 2015
Open
@hellomrcat hellomrcat mentioned this issue Jun 18, 2015
Closed
@hellomrcat hellomrcat mentioned this issue Jun 18, 2015
Closed
@klonos klonos changed the title [DX] move system_admin_bar_cache_info() into system.module [DX] move system_admin_bar_cache_info() into update.module Jun 19, 2015
@docwilmot docwilmot mentioned this issue May 27, 2018
Merged
@docwilmot docwilmot added this to the 1.11.0 milestone May 27, 2018
@klonos
Copy link
Member

klonos commented Sep 3, 2018 •
edited
Loading

I have approved the PR since it just verbatim moved two hooks/functions to their respectively appropriate places. The PR sandbox takes you to the installation wizard though. Not sure if this is a fail of the sandbox or caused by the PR somehow. @docwilmot can you please close and reopen the PR to refresh the sandbox? Thanks

@docwilmot
Copy link
Contributor

Rebooted, all is well. Feel free to RTBC.

@herbdool
Copy link

herbdool commented Sep 7, 2018

I checked too on test box. Looks good.

backdrop-ci referenced this issue in backdrop/backdrop Sep 9, 2018
@docwilmot @quicksketch
Issue #804: move hook_admin_bar_cache_info() into base modules.
83c2fcb 
By @docwilmot, @jenlampton, @klonos, and @herbdool.
@quicksketch
Copy link
Member

Looks great. Merged backdrop/backdrop#2212 into 1.x for 1.11.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status - fixed status - has pull request type - task
Projects
None yet
Milestone
1.11.0
Development

No branches or pull requests
7 participants
@quicksketch @jenlampton @docwilmot @herbdool @klonos @hellomrcat @Dinornis