Issue #197: Removed all instances of compact_link. #227
Conversation
|
Niiice, I like this change. It simplifies the administrative interface by removing this odd-ball functionality. This PR needs work however. It looks like this change is causing a bunch of PHP notices: Besides the notices, there is now no way to access |
| @@ -802,7 +802,6 @@ function theme_user_admin_permissions($variables) { | |||
| foreach (element_children($form['role_names']) as $rid) { | |||
| $header[] = array('data' => drupal_render($form['role_names'][$rid]), 'class' => array('checkbox')); | |||
| } | |||
| $output = theme('system_compact_link'); | |||
There was a problem hiding this comment.
Change this line to
$output = '';
Or set the line below to use = instead of .=, either approach is fine.
|
It looks like there are still a number of references to the |
|
Hi Ron, did you mean to delete this branch? I hadn't gotten it merged into the main project yet. It looked good to go, I just hadn't merged it yet. |
|
The patch is available https://github.com/backdrop/backdrop/pull/227.patch |
|
Thanks @andytruong, I was thinking the same thing. I can apply this manually and push it to 1.x. :) |
|
I’m trying to get a clean setup so I can add a new commit without having the changes from the previous PR included again. Probably being too wild about it but figured it was easy enough to recreate it all once I figure it out. The problem I’m having is the changed files in my previous PR keep getting added to my current PR. |
|
There we go, got it in there: 0c4bc5d |
|
Hey, you did it despite my bumbling. :-) |
…idly, only allow if matches email.
…idly, only allow if matches email.
…idly, only allow if matches email.
…idly, only allow if matches email.
…idly, only allow if matches email.
…idly, only allow if matches email.
…idly, only allow if matches email.
…idly, only allow if matches email.
…idly, only allow if matches email.
…idly, only allow if matches email.
…gidly, only allow if matches email.
Pull request for backdrop/backdrop-issues#197