Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Views: Date filter does not work with dynamic dates. #2625

Closed
wants to merge 2 commits into from

Conversation

@backdrop-ci
Copy link
Collaborator

Website: http://2625.backdrop.backdrop.qa.backdropcms.org
Username: admin
Password: GV6HA4MJ

@klonos
Copy link
Member Author

klonos commented Jul 26, 2019

Lets refresh the sandbox...

@klonos klonos closed this Jul 26, 2019
@backdrop-ci
Copy link
Collaborator

Website: http://2625.backdrop.backdrop.qa.backdropcms.org Removed

@klonos klonos reopened this Jul 26, 2019
@backdrop-ci
Copy link
Collaborator

Website: http://2625.backdrop.backdrop.qa.backdropcms.org
Username: admin
Password: qZ4XT9kC

@herbdool
Copy link
Contributor

herbdool commented Aug 6, 2019

Relevant tests are failing so this broke something.

@jenlampton
Copy link
Member

jenlampton commented Sep 5, 2019

@klonos looking at this failing test now... It looks like some of the patch didn't apply. We need to delete the following lines.

if ($this->value['type'] == 'offset') {
      $a = '***CURRENT_TIME***' . sprintf('%+d', $a); // keep sign
      $b = '***CURRENT_TIME***' . sprintf('%+d', $b); // keep sign
    }
``

@jenlampton jenlampton mentioned this pull request Sep 5, 2019
@jenlampton
Copy link
Member

Replaced by #2850

@jenlampton jenlampton closed this Sep 5, 2019
@backdrop-ci
Copy link
Collaborator

Website: http://2625.backdrop.backdrop.qa.backdropcms.org Removed

@klonos klonos deleted the patch-184 branch October 4, 2019 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants