Remove language_css_alter() (RTL stylesheets) in favor of HTML 'dir' attribute. #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
.rej files will appear (everywhere, as untracked files) until you delete them. Make sure you apply all the changes within first though! |
| .dropbutton-multiple .dropbutton li > * { | ||
| margin-left: 0.25em; | ||
| margin-right: 0; | ||
| } |
There was a problem hiding this comment.
I don't think this is correct. This patch should be removing all the -rtl.css files, and adding that code into the non-rtl versions.
|
Closing because this needs work. Please re-open when you have a new PR for review. |
|
pr for backdrop/backdrop-issues#207 |
|
Looks like @adamtothemoon does not have permission to re-open his own pull request. |
Issue #1684806 by nod_: JSHint progress.js.
| @@ -29,7 +44,7 @@ fieldset.vertical-tabs-pane > legend { | |||
| margin: 0; | |||
| } | |||
| .vertical-tabs .vertical-tabs-list a { | |||
| display: block; | |||
| display: block;gi | |||
|
Looks like there is a bunch of RTL sheets still unconverted in this PR. I've filed a replacement at #334 that includes all these changes plus the missing RTL stylesheets. |
jenlampton
pushed a commit
to jenlampton/backdrop
that referenced
this pull request
Jan 17, 2015
…rability of email.
jenlampton
pushed a commit
to jenlampton/backdrop
that referenced
this pull request
Mar 3, 2015
…rability of email.
jenlampton
pushed a commit
to jenlampton/backdrop
that referenced
this pull request
Mar 3, 2015
…rability of email.
jenlampton
pushed a commit
to jenlampton/backdrop
that referenced
this pull request
Apr 24, 2015
…rability of email.
quicksketch
added a commit
that referenced
this pull request
May 8, 2015
Issue #305: Set fixed From and add Reply-to to improve deliverability of email.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pr for: backdrop/backdrop-issues#207
For some reason the .rej files appear in all branches not just the one I was working on. Any idea why that would be?