Issue #5150: LiteSpeed uploadprogress detection. #3985
Conversation
|
Related to: backdrop/backdrop-issues#5150 |
|
Tugboat has finished building a preview for this pull request! Website: https://pr3985-383evlobe2fnzemnjy5lcqtkwxvkertr.tugboat.qa/ |
| $fastcgi = FALSE; | ||
| if ($is_apache) { | ||
| $fastcgi = strpos($server_software, 'mod_fastcgi') !== FALSE || strpos($server_software, 'mod_fcgi') !== FALSE; | ||
| } | ||
|
|
||
| $description = NULL; | ||
| if (!$is_apache && !$is_nginx) { | ||
| if (!$is_apache && !$is_nginx && !$is_litespeed) { | ||
| $value = t('Not enabled'); | ||
| $description = t('Your server is not capable of displaying file upload progress. File upload progress requires an Apache server running PHP with mod_php or Nginx with PHP-FPM.'); |
There was a problem hiding this comment.
Should this line (249) be updated also, or did you purposefully not add LiteSpeed here as it is not yet officially supported?
There was a problem hiding this comment.
Right! We should update the description too, IMO.
|
@quicksketch - I've tested this on my LiteSpeed hosting and it works as expected. I've added a comment as to whether we should also update the text in line 249. |
|
Tugboat has finished building a preview for this pull request! Website: https://pr3985-383evlobe2fnzemnjy5lcqtkwxvkertr.tugboatqa.com/ This preview will automatically expire on the 20th of July, 2022. |
|
@quicksketch - I was made aware that this is still open as Dragon Bot emailed me to notify of a new tugboat preview. Should just need some text changing to get this over the line. Are you able to do this? I could try but I'm not quite sure how to take over an existing PR yet. |
| $fastcgi = FALSE; | ||
| if ($is_apache) { | ||
| $fastcgi = strpos($server_software, 'mod_fastcgi') !== FALSE || strpos($server_software, 'mod_fcgi') !== FALSE; | ||
| } | ||
|
|
||
| $description = NULL; | ||
| if (!$is_apache && !$is_nginx) { | ||
| if (!$is_apache && !$is_nginx && !$is_litespeed) { | ||
| $value = t('Not enabled'); | ||
| $description = t('Your server is not capable of displaying file upload progress. File upload progress requires an Apache server running PHP with mod_php or Nginx with PHP-FPM.'); |
There was a problem hiding this comment.
| $description = t('Your server is not capable of displaying file upload progress. File upload progress requires an Apache server running PHP with mod_php or Nginx with PHP-FPM.'); | |
| $description = t('Your server is not capable of displaying file upload progress. File upload progress requires an Apache or LiteSpeed server running PHP with mod_php or Nginx with PHP-FPM.'); |
Builds on the PR for backdrop/backdrop-issues#5524 (that must be merged first).
Fixes backdrop/backdrop-issues#5150.