Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4961 Adding Basic Files Permissions for Editor #4420

Merged

Conversation

stpaultim
Copy link
Member

@stpaultim
Copy link
Member Author

stpaultim commented May 1, 2023

I'm not sure how to fix the coding standard error in line 438.

Error: <error line="438" column="87" severity="error" message="String concat is not required here; use a single string instead" source="Generic.Strings.UnnecessaryStringConcat.Found"/>
Error: String concat is not required here; use a single string instead

@klonos
Copy link
Member

klonos commented May 1, 2023

@stpaultim can you please try changing that to the following:

$image_url = BACKDROP_ROOT . '/' . backdrop_get_path('profile', 'standard') . '/images/' . $image_filename;

@stpaultim stpaultim force-pushed the 4961-Editor-Permission-Manage-Files branch from 3d40755 to ee1a7ea Compare December 27, 2023 07:16
@docwilmot
Copy link
Contributor

Needs rebasing, logs and sandbox have expired.

@quicksketch quicksketch force-pushed the 4961-Editor-Permission-Manage-Files branch from 023dc14 to c099339 Compare April 28, 2024 02:28
@dragonbot
Copy link
Collaborator

Tugboat has finished building a preview for this pull request!

Website: https://pr4420-pbglusjmsi8r7ujoedaaztgtoeumfpu0.tugboatqa.com/
Username: admin
Password: 058054e67f98

This preview will automatically expire on the 28th of June, 2024.

@quicksketch quicksketch merged commit 2fb5cd1 into backdrop:1.x Apr 28, 2024
12 checks passed
@quicksketch
Copy link
Member

Merged into 1.x for 1.28.0. Thanks @stpaultim!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants