Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #6420: Strengthen user_pass_rehash() #4673

Merged
merged 9 commits into from Apr 27, 2024
Merged

Issue #6420: Strengthen user_pass_rehash() #4673

merged 9 commits into from Apr 27, 2024

Conversation

herbdool
Copy link
Contributor

@backdrop-ci
Copy link
Collaborator

Related to: backdrop/backdrop-issues#6420

@herbdool
Copy link
Contributor Author

herbdool commented Mar 17, 2024 •
edited

I think I found a case where fixing the coding standard breaks things in PHP 5.6:

PHP Parse error: syntax error, unexpected ')' in /home/runner/work/backdrop/backdrop/core/modules/user/user.module on line 622

All other PHP versions are fine. And my IDE says it's fine. And me manually counting the open and close brackets says its fine. Sigh. So I'm going to revert that line and let it complain.

klonos
klonos reviewed Apr 25, 2024
View reviewed changes
.cspell/backdrop.dic Outdated
Comment on lines 1 to 2
abcdefghijklmnopqrstuvwx
abcdefghijkmnopqrstuvwxyz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please remove this addition here?

This is non-sensical and only used once in our codebase, so better wrap the line where this is used in // cspell:disable/// cspell:enable instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this one is nonsensical, so is the previous one, which ends at x for some reason.

klonos
klonos reviewed Apr 25, 2024
View reviewed changes
.cspell/backdrop.dic Outdated Show resolved Hide resolved
@dragonbot
Copy link
Collaborator

Tugboat has finished building a preview for this pull request!

Website: https://pr4673-2yf9azhur7pk9zs7ae8vcbxntwqsmweg.tugboatqa.com/
Username: admin
Password: 7d8c9a2342d0

This preview will automatically expire on the 25th of June, 2024.

@quicksketch quicksketch merged commit 3817a40 into backdrop:1.x Apr 27, 2024
11 of 12 checks passed
@quicksketch
Copy link
Member

Merged into 1.x and 1.27.x. Thanks @herbdool!

@quicksketch quicksketch mentioned this pull request Apr 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klonos klonos klonos left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@herbdool @backdrop-ci @dragonbot @quicksketch @klonos