-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove peer dependencies #32
Conversation
Alternative to backflip#31, also fixes backflip#29
(or one of it's sub-modules) now that npm won't enforce that for us.
@nfroidure Since peer dependencies do not exist anymore: Would you specify |
I think people will have to keep installing it as a separate dependency unless we make significant changes to this module to have it actually use gulp-iconfont internally. (If the user has to |
The advantage would be that we could specify a version range which is compatible with this plugin. |
Yea, its really not a bad idea, its just that its more involved than the quick-fix here. |
Fair enough. But we need it as a |
So, now that I'm looking at the code more closely, it might not be so hard to just pipe to gulp-iconfont internally, then we'd have it as a regular dependency and users won't even need to install it. Let me see if I can put it together today or tomorrow... |
@nfroidure Would you be fine with adapting this plugin to use For some context: As mentioned in the README, this plugin is not really necessary. Instead, the |
@nfriedly On second thought: Let's not use |
Sounds good, just a minute. |
No pressure, I will be back in about 8 hours. |
Bump gulp-iconfont to v5
Free as in freedom ;) gulp-iconfont bundles: gulp-svgicons2svgfont gulp-svg2ttf gulp-ttf2woff gulp-ttf2woff2 etc... I'm ok with any use of gulp-iconfont :). |
Okay. :) @nfriedly: Thanks again, released with 2.0.0. |
Awesome, thanks! |
Alternative to #31, also fixes #29