-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Buffer.from to to remove deprecation warning #49
Conversation
@dovidweisz Thanks! Is this backwards compatible with Node 6.x and 4.x? What other changes you advice to stay on track with the new Buffer changes in Node 7? |
@jefsnare looks like Buffer.from wasn't added until v5.10.0. But I'll code around it if necessary. |
@dovidweisz Would be great if you want to, since we don't want to break older Node.js environments for now. Agree that from Release 3 we should mention that we support 5.10 and above? |
... I am in no way an authority on Buffer (or Nodejs for that matter ). But this was the only depreciation warning that we were getting. |
@dovidweisz okay great. Is it possible to apply the changes before Release 2.2.0? |
I think that on a new release you should only commit to supporting one full version back. So if the current stable version is 7.x, you should give support back to 6.x. |
@dovidweisz sounds good to me, @backflip what are your thoughts? |
I plan on getting to it today or tomorrow. |
I'm doing some testing now and it seems like node 4.x is fine with |
@dovidweisz thanks! |
@jefsnare is there any way we can move this release? |
Using this plugin with node7 outputs this warning to the console