cli: fix for node_modules inside local packages being transformed

backstage · Dec 7, 2020 · 0117081 · 0117081
1 parent a1fffce
commit 0117081
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/.changeset/fast-frogs-wave.md b/.changeset/fast-frogs-wave.md
@@ -0,0 +1,5 @@
+---
+'@backstage/cli': patch
+---
+
+Fixes a big in the bundling logic that caused `node_modules` inside local monorepo packages to be transformed.
diff --git a/packages/cli/src/lib/bundler/transforms.ts b/packages/cli/src/lib/bundler/transforms.ts
@@ -35,7 +35,12 @@ export const transforms = (options: TransformOptions): Transforms => {
   const extraTransforms = isDev ? ['react-hot-loader'] : [];
 
   const transformExcludeCondition = {
-    and: [/node_modules/, { not: externalTransforms }],
+    or: [
+      // This makes sure we don't transform node_modules inside any of the local monorepo packages
+      /node_modules.*node_modules/,
+      // This excludes the local monorepo packages from the excludes, meaning they will be transformed
+      { and: [/node_modules/, { not: externalTransforms }] },
+    ],
   };
 
   const loaders = [