cli: fix for backend bundle building all packages

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
backstage · Nov 13, 2021 · 4ca3542 · 4ca3542
1 parent af855da
commit 4ca3542
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 11 deletions.
diff --git a/.changeset/sour-cameras-hide.md b/.changeset/sour-cameras-hide.md
@@ -0,0 +1,5 @@
+---
+'@backstage/cli': patch
+---
+
+Fixed a bug where calling `backstage-cli backend:bundle --build-dependencies` with no dependencies to be built would cause all monorepo packages to be built instead.
diff --git a/packages/cli/src/lib/packager/index.ts b/packages/cli/src/lib/packager/index.ts
@@ -106,18 +106,19 @@ export async function createDistWorkspace(
 
   if (options.buildDependencies) {
     const exclude = options.buildExcludes ?? [];
-    const scopeArgs = targets
-      .filter(target => !exclude.includes(target.name))
-      .flatMap(target => ['--scope', target.name]);
 
-    const lernaArgs =
-      options.parallel && Number.isInteger(options.parallel)
-        ? ['--concurrency', options.parallel.toString()]
-        : [];
-
-    await run('yarn', ['lerna', ...lernaArgs, 'run', ...scopeArgs, 'build'], {
-      cwd: paths.targetRoot,
-    });
+    const toBuild = targets.filter(target => !exclude.includes(target.name));
+    if (toBuild.length > 0) {
+      const scopeArgs = toBuild.flatMap(target => ['--scope', target.name]);
+      const lernaArgs =
+        options.parallel && Number.isInteger(options.parallel)
+          ? ['--concurrency', options.parallel.toString()]
+          : [];
+
+      await run('yarn', ['lerna', ...lernaArgs, 'run', ...scopeArgs, 'build'], {
+        cwd: paths.targetRoot,
+      });
+    }
   }
 
   await moveToDistWorkspace(targetDir, targets);