Skip to content

Commit

Permalink
Introduce the Context to the backend again
Browse files Browse the repository at this point in the history
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
  • Loading branch information
freben committed Jan 24, 2022
1 parent 64700a1 commit 50d0395
Show file tree
Hide file tree
Showing 12 changed files with 689 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .changeset/rare-comics-tan.md
@@ -0,0 +1,5 @@
---
'@backstage/backend-common': patch
---

Added a Context class for the backend, that handles aborting, timeouts, api resolution etc
42 changes: 42 additions & 0 deletions packages/backend-common/api-report.md
Expand Up @@ -12,7 +12,9 @@ import { AzureIntegration } from '@backstage/integration';
import { BitbucketIntegration } from '@backstage/integration';
import { Config } from '@backstage/config';
import cors from 'cors';
import { DateTime } from 'luxon';
import Docker from 'dockerode';
import { Duration } from 'luxon';
import { ErrorRequestHandler } from 'express';
import express from 'express';
import { GithubCredentialsProvider } from '@backstage/integration';
Expand Down Expand Up @@ -145,6 +147,27 @@ export interface ContainerRunner {
runContainer(opts: RunContainerOptions): Promise<void>;
}

// @public
export interface Context {
readonly abortPromise: Promise<void>;
readonly abortSignal: AbortSignal;
readonly deadline: DateTime | undefined;
value<T = unknown>(key: string | symbol): T | undefined;
with(...decorators: ContextDecorator[]): Context;
withAbort(): {
ctx: Context;
abort: () => void;
};
withTimeout(timeout: Duration): Context;
withValue<T = unknown>(
key: string | symbol,
value: T | ((previous: T | undefined) => T),
): Context;
}

// @public
export type ContextDecorator = (ctx: Context) => Context;

// @public @deprecated
export const createDatabase: typeof createDatabaseClient;

Expand Down Expand Up @@ -456,6 +479,25 @@ export function resolvePackagePath(name: string, ...paths: string[]): string;
// @public
export function resolveSafeChildPath(base: string, path: string): string;

// @public
export class RootContext implements Context {
get abortPromise(): Promise<void>;
get abortSignal(): AbortSignal_2;
static create(): Context;
get deadline(): DateTime | undefined;
value<T = unknown>(key: string | symbol): T | undefined;
with(...items: ContextDecorator[]): Context;
withAbort(): {
ctx: Context;
abort: () => void;
};
withTimeout(timeout: Duration): Context;
withValue<T = unknown>(
key: string | symbol,
value: T | ((previous: T | undefined) => T),
): Context;
}

// @public
export type RunContainerOptions = {
imageName: string;
Expand Down
2 changes: 2 additions & 0 deletions packages/backend-common/package.json
Expand Up @@ -41,6 +41,7 @@
"@types/cors": "^2.8.6",
"@types/dockerode": "^3.3.0",
"@types/express": "^4.17.6",
"@types/luxon": "^2.0.4",
"archiver": "^5.0.2",
"aws-sdk": "^2.840.0",
"compression": "^1.7.4",
Expand All @@ -59,6 +60,7 @@
"knex": "^0.95.1",
"lodash": "^4.17.21",
"logform": "^2.3.2",
"luxon": "^2.0.2",
"minimatch": "^3.0.4",
"minimist": "^1.2.5",
"morgan": "^1.10.0",
Expand Down
60 changes: 60 additions & 0 deletions packages/backend-common/src/context/RootContext.test.ts
@@ -0,0 +1,60 @@
/*
* Copyright 2021 The Backstage Authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

import { Duration } from 'luxon';
import { RootContext } from './RootContext';

describe('RootContext', () => {
it('can perform a manual abort', async () => {
const { ctx, abort } = RootContext.create().withAbort();

const cb = jest.fn();
ctx.abortSignal.addEventListener('abort', cb);
ctx.abortPromise.then(cb);

abort();

await ctx.abortPromise;
expect(cb).toBeCalledTimes(2);
});

it('can abort on a timeout', async () => {
const ctx = RootContext.create().withTimeout(Duration.fromMillis(200));
const start = Date.now();

const cb = jest.fn();
ctx.abortSignal.addEventListener('abort', cb);
ctx.abortPromise.then(cb);

await ctx.abortPromise;
const delta = Date.now() - start;

expect(delta).toBeGreaterThan(100);
expect(delta).toBeLessThan(300);
expect(cb).toBeCalledTimes(2);
});

it('can apply behaviors', () => {
const ctx = RootContext.create().with(
c => c.withValue('a', 1),
c => c.withValue<number>('a', p => p! + 1),
c => c.withValue('b', 3),
);

expect(ctx.value('a')).toBe(2);
expect(ctx.value('b')).toBe(3);
});
});
123 changes: 123 additions & 0 deletions packages/backend-common/src/context/RootContext.ts
@@ -0,0 +1,123 @@
/*
* Copyright 2021 The Backstage Authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

import { DateTime, Duration } from 'luxon';
import { AbortSignal } from 'node-abort-controller';
import {
abortManually,
abortOnTimeout,
ContextAbortState,
} from './features/abort';
import {
ContextValues,
findInContextValues,
unshiftContextValues,
} from './features/values';
import { Context, ContextDecorator } from './types';

// The context value key used for holding abort related state
const abortKey = Symbol('Context.abort');

/**
* A context that is meant to be passed as a ctx variable down the call chain,
* to pass along scoped information and abort signals.
*
* @public
*/
export class RootContext implements Context {
/**
* Creates a root context.
*
* @remarks
*
* This should normally only be called near the root of an application. The
* created context is meant to be passed down into deeper levels, which may
* or may not make derived contexts out of it.
*/
static create() {
return new RootContext(undefined).withValue<ContextAbortState>(
abortKey,
abortManually(),
);
}

/**
* {@inheritdoc Context.abortSignal}
*/
public get abortSignal(): AbortSignal {
return this.value<ContextAbortState>(abortKey)!.signal;
}

/**
* {@inheritdoc Context.abortPromise}
*/
public get abortPromise(): Promise<void> {
return this.value<ContextAbortState>(abortKey)!.promise;
}

/**
* {@inheritdoc Context.deadline}
*/
public get deadline(): DateTime | undefined {
return this.value<ContextAbortState>(abortKey)!.deadline;
}

private constructor(private readonly values: ContextValues) {}

/**
* {@inheritdoc Context.withAbort}
*/
withAbort(): { ctx: Context; abort: () => void } {
const state = abortManually(this.value<ContextAbortState>(abortKey));
return {
ctx: this.withValue(abortKey, state),
abort: state.abort,
};
}

/**
* {@inheritdoc Context.withTimeout}
*/
withTimeout(timeout: Duration): Context {
return this.withValue<ContextAbortState>(abortKey, previous =>
abortOnTimeout(timeout, previous),
);
}

/**
* {@inheritdoc Context.with}
*/
with(...items: ContextDecorator[]): Context {
return items.reduce<Context>((prev, curr) => curr(prev), this);
}

/**
* {@inheritdoc Context.withValue}
*/
withValue<T = unknown>(
key: string | symbol,
value: T | ((previous: T | undefined) => T),
): Context {
return new RootContext(unshiftContextValues(this.values, key, value));
}

/**
* {@inheritdoc Context.value}
*/
value<T = unknown>(key: string | symbol): T | undefined {
return findInContextValues<T>(this.values, key);
}
}

0 comments on commit 50d0395

Please sign in to comment.