Merge pull request #25321 from backstage/blam/fix-package-bundling

Fix subpath bundling issues
backstage · Jun 19, 2024 · 7862133 · 7862133
2 parents a934435 + cb14a05
commit 7862133
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/.changeset/rare-peas-dream.md b/.changeset/rare-peas-dream.md
@@ -0,0 +1,5 @@
+---
+'@backstage/backend-defaults': patch
+---
+
+Repack the package to fix issues with typescript with named exports
diff --git a/.changeset/silent-experts-move.md b/.changeset/silent-experts-move.md
@@ -0,0 +1,5 @@
+---
+'@backstage/cli': patch
+---
+
+Subpath export `package.json` should be of a unique name to avoid typescript resolution issues
diff --git a/packages/cli/src/lib/packager/productionPack.ts b/packages/cli/src/lib/packager/productionPack.ts
@@ -180,7 +180,9 @@ async function prepareExportsEntryPoints(
         await fs.writeJson(
           resolvePath(entryPointDir, PKG_PATH),
           {
-            name: pkg.name,
+            // Need a temporary name, as sharing the same name causes some typescript issues with caching of packages names
+            // And their defined `types` field.
+            name: `${pkg.name}__${entryPoint.name.toLocaleLowerCase('en-US')}`,
             version: pkg.version,
             ...(exp.default ? { main: posixPath.join('..', exp.default) } : {}),
             ...(exp.import ? { module: posixPath.join('..', exp.import) } : {}),