Skip to content

Commit

Permalink
pr suggestions
Browse files Browse the repository at this point in the history
Signed-off-by: therynamo <theryn.groetken@gemini.com>
  • Loading branch information
therynamo committed Nov 15, 2021
1 parent 16f7180 commit 9e64a7a
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
---
'@backstage/techdocs-common': patch
'@backstage/techdocs-backend': patch
---

Allow amazon web services s3 buckets to pass an server side encryption configuration so they can publish to encrypted buckets
1 change: 1 addition & 0 deletions docs/features/techdocs/configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ techdocs:
s3ForcePathStyle: false

# (Optional) AWS Server Side Encryption
# Defaults to undefined.
# If not set, encrypted buckets will fail to publish.
# https://docs.aws.amazon.com/AmazonS3/latest/userguide/specifying-s3-encryption.html
sse: 'aws:kms' # or AES256
Expand Down
8 changes: 8 additions & 0 deletions plugins/techdocs-backend/config.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,14 @@ export interface Config {
* @visibility backend
*/
s3ForcePathStyle?: boolean;

/**
* (Optional) AWS Server Side Encryption
* Defaults to undefined.
* If not set, encrypted buckets will fail to publish.
* https://docs.aws.amazon.com/AmazonS3/latest/userguide/specifying-s3-encryption.html
*/
sse: 'aws:kms' | 'AES256';
};
}
| {
Expand Down

0 comments on commit 9e64a7a

Please sign in to comment.