Merge pull request #9482 from daviddyball/master

scaffolder-backend: fix error behaviour in runCommand helper
backstage · Feb 11, 2022 · a57621b · a57621b
2 parents fedb830 + 3e59f90
commit a57621b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/.changeset/brown-impalas-greet.md b/.changeset/brown-impalas-greet.md
@@ -0,0 +1,6 @@
+---
+'@backstage/plugin-scaffolder-backend': patch
+---
+
+Fix error handling of the `runCommand` helper to return `Error`
+instance.
diff --git a/plugins/scaffolder-backend/src/scaffolder/actions/builtin/helpers.ts b/plugins/scaffolder-backend/src/scaffolder/actions/builtin/helpers.ts
@@ -58,7 +58,9 @@ export const runCommand = async ({
 
     process.on('close', code => {
       if (code !== 0) {
-        return reject(`Command ${command} failed, exit code: ${code}`);
+        return reject(
+          new Error(`Command ${command} failed, exit code: ${code}`),
+        );
       }
       return resolve();
     });