feat: hide owned selector picker if user doesn't own an entity

Signed-off-by: djamaile <rdjamaile@gmail.com>
backstage · Nov 23, 2021 · c6fddde · c6fddde
1 parent 59dc704
commit c6fddde
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 3 deletions.
diff --git a/.changeset/modern-buses-protect.md b/.changeset/modern-buses-protect.md
@@ -0,0 +1,5 @@
+---
+'@backstage/plugin-catalog-react': patch
+---
+
+when a user doesn't own any entity, the user won't get the option to select on owned
diff --git a/plugins/catalog-react/src/components/UserListPicker/UserListPicker.tsx b/plugins/catalog-react/src/components/UserListPicker/UserListPicker.tsx
@@ -176,12 +176,14 @@ export const UserListPicker = ({
     setEntitiesWithoutUserFilter(backendEntities.filter(filterFn));
   }, [filters, backendEntities]);
 
+  const totalOwnedUserEntities = entitiesWithoutUserFilter.filter(entity =>
+    ownedFilter.filterEntity(entity),
+  ).length;
+
   function getFilterCount(id: UserListFilterKind) {
     switch (id) {
       case 'owned':
-        return entitiesWithoutUserFilter.filter(entity =>
-          ownedFilter.filterEntity(entity),
-        ).length;
+        return totalOwnedUserEntities;
       case 'starred':
         return entitiesWithoutUserFilter.filter(entity =>
           starredFilter.filterEntity(entity),
@@ -191,6 +193,20 @@ export const UserListPicker = ({
     }
   }
 
+  function removeListItem(
+    arr: ButtonGroup[],
+    itemID: 'all' | 'owned' | 'starred',
+  ): ButtonGroup[] {
+    const index = arr[0].items.map(item => item.id).indexOf(itemID);
+    arr[0].items.splice(index, 1);
+    return arr;
+  }
+
+  // should we do the same for starred?
+  if (totalOwnedUserEntities < 1) {
+    removeListItem(filterGroups, 'owned');
+  }
+
   return (
     <Card className={classes.root}>
       {filterGroups.map(group => (