auth-backend: throw error if OIDC IdP does not have a userinfo endpoint

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
backstage · Sep 10, 2021 · de57178 · de57178
1 parent 977710c
commit de57178
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/.changeset/polite-dragons-allow.md b/.changeset/polite-dragons-allow.md
@@ -0,0 +1,5 @@
+---
+'@backstage/plugin-auth-backend': patch
+---
+
+Use a more informative error message if the configured OIDC identity provider does not provide a `userinfo_endpoint` in its metadata.
diff --git a/plugins/auth-backend/src/providers/oidc/provider.ts b/plugins/auth-backend/src/providers/oidc/provider.ts
@@ -157,6 +157,11 @@ export class OidcAuthProvider implements OAuthHandlers {
         userinfo: UserinfoResponse,
         done: PassportDoneCallback<AuthResult, PrivateInfo>,
       ) => {
+        if (typeof done !== 'function') {
+          throw new Error(
+            'OIDC IdP must provide a userinfo_endpoint in the metadata response',
+          );
+        }
         done(
           undefined,
           { tokenset, userinfo },